Repository navigation
Fix Colorbar extend patches to have correct alpha - #23260
Merged
oscargus merged 1 commit intoJun 14, 2022
Merged
oscargus merged 1 commit into
oscargus merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
timhoffm
approved these changes
Jun 13, 2022
oscargus
approved these changes
Jun 14, 2022
jklymak
reviewed
Jun 14, 2022
jklymak
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Post-facto, but it would be nice if a test were added for this...
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I thought about that as well, but then couldn't really come up with anything better than an image test. I'll add one in #22865. Edit: I can add one elsewhere. Realized that I had messed up my local handling of #22865. |
Sorry, something went wrong.
This was referenced Jun 14, 2022
Copy link
Copy Markdown
Member
|
meeseeksdev backport to v3.5.x |
Sorry, something went wrong.
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jun 15, 2022
QuLogic
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jun 21, 2022
timhoffm
added a commit
that referenced
this pull request
Jun 21, 2022
…260-on-v3.5.x Backport PR #23260 on branch v3.5.x (Fix Colorbar extend patches to have correct alpha)
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Add self.alpha to PathPatch creation in _do_extends method in order for the extend patches of the colorbar to have the correct alpha. (closes #22970)
PR Checklist
Tests and Styling
Documentation