Repository navigation
Simplify binary data handling in ps backend. - #23294
timhoffm merged 1 commit into
Conversation
Sorry, something went wrong.
oscargus
left a comment
There was a problem hiding this comment.
The only potential "problem" is that the deprecation note says: "Vendor the code of the similarly named private functions if you rely on these functions." https://github.com/matplotlib/matplotlib/blob/main/doc/api/next_api_changes/deprecations/22797-OG.rst
But hopefully people will understand anyway (there are several functions deprecated, so probably not worthwhile special handling this one).
Sorry, something went wrong.
|
Oh, if there is a suitable test to add that would be great! (Or are the lines actually tested despite the report?) |
Sorry, something went wrong.
|
It is quite possible that this is actually not tested; will add a test... |
Sorry, something went wrong.
|
Test added. |
Sorry, something went wrong.
- bytes.hex() can now perform linewrapping itself, so use that in draw_image. - draw_gouraud_triangles can rely on PostScript's hexstring format (`<...>` instead of `(...)`) and thus on bytes.hex() too. This makes _quote_ps_string fully unused, thus tweak the deprecation of quote_ps_string. Also add a test for PostScript Gouraud shading, which was previously not covered at all.
draw_image.
(<...> instead of (...)) and thus on bytes.hex() too. This makes
_quote_ps_string fully unused, thus tweak the deprecation of
quote_ps_string.
PR Summary
PR Checklist
Tests and Styling
Documentation