FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Compare thread native ids when checking whether running on main thread. by anntzer · Pull Request #23445 · matplotlib/matplotlib · GitHub

Repository navigation

Compare thread native ids when checking whether running on main thread. - #23445

Merged
QuLogic merged 1 commit into
matplotlib:mainfrom
anntzer:tnid
Jul 20, 2022
Merged

QuLogic merged 1 commit into
matplotlib:mainfrom
anntzer:tnid

Conversation

anntzer commented Jul 18, 2022

Copy link
Copy Markdown
Contributor

PR Summary

See #23419 (comment). Regardless of how that entire issue gets resolved, the check here just seems better?

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

QuLogic added this to the v3.5.3 milestone Jul 20, 2022
QuLogic merged commit 11a3e1b into matplotlib:main Jul 20, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jul 20, 2022

QuLogic commented Jul 21, 2022

Copy link
Copy Markdown
Member

Looks like that's 3.8+, so we can't backport this.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL