FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Get Mathtext `\times` symbol from `cmsy10` when using `cmr10`. by tfpf · Pull Request #23702 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Get Mathtext \times symbol from cmsy10 when using cmr10. - #23702

Merged
timhoffm merged 2 commits into
matplotlib:mainfrom
tfpf:cmr10_cmsy10_substitutions
Oct 6, 2022
ConversationCommits (2)ChecksFiles changed
Merged

Get Mathtext \times symbol from cmsy10 when using cmr10.#23702
timhoffm merged 2 commits into
matplotlib:mainfrom
tfpf:cmr10_cmsy10_substitutions

Conversation

tfpf commented Aug 22, 2022

Copy link
Copy Markdown
Contributor

PR Summary

Fixes #10029.

import matplotlib.pyplot as plt
plt.rcdefaults()
plt.rc('font', family=['cmr10'])
plt.rc('mathtext', fontset='cm')
plt.rc('axes.formatter', use_mathtext=True)
plt.semilogy([-0.03, 0.05], [0.3, 0.05])
plt.show()

I felt that having all glyph fixes in the same place would result in cleaner code. This will also be easy to extend if, in the future, we plan to add more glyph substitutions.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).

oscargus approved these changes Aug 22, 2022
View reviewed changes

oscargus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

One may consider a test. but I cannot really tell what would be the simplest test as a normal text with `\times' does already work.

tfpf commented Aug 22, 2022

Copy link
Copy Markdown
Contributor Author

I think testing this isn't straightforward, since the missing multiplication sign logs a warning, but doesn't raise a user warning. (Otherwise, something similar to #20235 could be used to detect it.)

One thing I missed: cmr10_cmsy10_substitutions should probably be private; the way it is used seems to be an implementation detail.

anntzer commented Aug 22, 2022

Copy link
Copy Markdown
Contributor

Perhaps https://docs.pytest.org/en/7.1.x/how-to/logging.html#caplog-fixture can help.

oscargus commented Aug 22, 2022

Copy link
Copy Markdown
Member

I was more thinking about testing that the multiplication sign shows up (instead of ¤), rather than the warning thing.

tfpf force-pushed the cmr10_cmsy10_substitutions branch from ba3891d to 077ea7c Compare August 22, 2022 16:35

tfpf commented Aug 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I was more thinking about testing that the multiplication sign shows up (instead of ¤), rather than the warning thing.

I think this would require an image comparison test? I could add it if required.

tfpf commented Aug 22, 2022
View reviewed changes
Comment thread lib/matplotlib/tests/test_ticker.py

tfpf commented Aug 23, 2022

Copy link
Copy Markdown
Contributor Author

Strange. How did the code coverage decrease. There are no uncovered lines reported in the diff.

oscargus commented Aug 24, 2022

Copy link
Copy Markdown
Member

I do not really understand how that test works, but it does fail from time to time, so no worries about it. (Except for maybe people not reviewing as the build "fails" anyway...)

oscargus added this to the v3.7.0 milestone Aug 30, 2022
tfpf force-pushed the cmr10_cmsy10_substitutions branch from 48192cc to f53301d Compare October 4, 2022 18:11
timhoffm merged commit 7f758c6 into matplotlib:main Oct 6, 2022
tfpf deleted the cmr10_cmsy10_substitutions branch October 6, 2022 16:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

timhoffm timhoffm approved these changes
oscargus oscargus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.7.0

Development

Successfully merging this pull request may close these issues.

\times in minor ticklabels not recognized due to \mathdefault

4 participants

Back | FazBrowse Home | New Git URL