Repository navigation
Use cleaner recursion check in PyQt FigureCanvas' resizeEvent. - #23729
tacaswell merged 1 commit into
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
Sorry, something went wrong.
…ureCanvas' resizeEvent.
|
Thank you @anthepro for this PR and tracking down the underlying problem! Congratulations on your first merged Matplotlib PR 🎉 Hopefully we will hear from you again! |
Sorry, something went wrong.
…729-on-v3.6.x Backport PR #23729 on branch v3.6.x (Use cleaner recursion check in PyQt FigureCanvas' resizeEvent.)
As suggested in issue #22409, using sys._getframe can lead to a memory leak which then causes PyQt to send the wrong event type. This solves the issue by and using a cleaner solution which avoids sys._getframe for determining recursion.