FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Clarify error for colorbar with unparented mappable by QuLogic · Pull Request #23740 · matplotlib/matplotlib · GitHub

Repository navigation

Clarify error for colorbar with unparented mappable - #23740

Merged
timhoffm merged 1 commit into
matplotlib:mainfrom
QuLogic:parentless-mappable
Aug 26, 2022
Merged

timhoffm merged 1 commit into
matplotlib:mainfrom
QuLogic:parentless-mappable

Conversation

QuLogic commented Aug 25, 2022

Copy link
Copy Markdown
Member

PR Summary

Fixes #23709

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

tacaswell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

modulo the suggested changes to the deprecation note.

QuLogic force-pushed the parentless-mappable branch from 6ada95f to 5509ebb Compare August 25, 2022 23:13
tacaswell added this to the v3.6.0 milestone Aug 25, 2022
timhoffm merged commit 86d5797 into matplotlib:main Aug 26, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Aug 26, 2022
QuLogic deleted the parentless-mappable branch August 26, 2022 07:37
QuLogic added a commit that referenced this pull request Aug 26, 2022
…740-on-v3.6.x

Backport PR #23740 on branch v3.6.x (Clarify error for colorbar with unparented mappable)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: colorbar with unattached mappables can't steal space

3 participants


Back | FazBrowse Home | New Git URL