FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Expire parameter renaming and deletion and attribute privatization from 3.5 by oscargus · Pull Request #23874 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Expire parameter renaming and deletion and attribute privatization from 3.5 - #23874

Closed
oscargus wants to merge 1 commit into
matplotlib:mainfrom
oscargus:remove35parameters
ConversationCommits (1)ChecksFiles changed
Closed

Expire parameter renaming and deletion and attribute privatization from 3.5#23874
oscargus wants to merge 1 commit into
matplotlib:mainfrom
oscargus:remove35parameters

Conversation

oscargus commented Sep 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

Will add a (quite long) release note.

Skipped widgets.py as it was a bit confusing at stages. But apart from that all renaming, deletion and privatization should be gone.

PR Checklist

Tests and Styling

  • [N/A] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

oscargus added API: changes Changes to the public API, typically requiring deprecation. Maintenance labels Sep 11, 2022
oscargus added this to the v3.7.0 milestone Sep 11, 2022
anntzer reviewed Sep 11, 2022
View reviewed changes
Comment thread lib/matplotlib/backends/backend_agg.py

@_api.delete_parameter("3.5", "args")
def print_png(self, filename_or_obj, *args,
def print_png(self, filename_or_obj,

anntzer Sep 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Once you expire a delete_parameter, all subsequent parameters also become kwonly (as it was impossible to pass them positionally during the deprecation period without triggering the deprecation). Ditto for all other instances below.

oscargus Sep 11, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I was thinking about that. Makes sense!

QuLogic commented Sep 12, 2022

Copy link
Copy Markdown
Member

For the removal notes, please add a bit more context than last time. When X is removed from Y where Y is 3 levels deep in an import tree, it is very hard to tell whether it's a relevant thing. See the changes in #23814 for examples.

oscargus commented Sep 13, 2022

Copy link
Copy Markdown
Member Author

I've realized that the release notes is really the problem here. It may be that I close this and do parts gradually as for some of these I do not really have much context and the earlier notes does not give much info either.

oscargus commented Oct 8, 2022

Copy link
Copy Markdown
Member Author

Closing this as it must be done in steps to be manageable.

oscargus closed this Oct 8, 2022
oscargus deleted the remove35parameters branch October 8, 2022 07:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anntzer anntzer left review comments

Assignees

No one assigned

Labels

API: changes Changes to the public API, typically requiring deprecation. Maintenance

Projects

None yet

Milestone

v3.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL