FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

added a reversing section to colormap reference by story645 · Pull Request #23904 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

added a reversing section to colormap reference - #23904

Merged
timhoffm merged 1 commit into
matplotlib:mainfrom
story645:color
Sep 24, 2022
ConversationCommits (1)ChecksFiles changed
Merged

added a reversing section to colormap reference#23904
timhoffm merged 1 commit into
matplotlib:mainfrom
story645:color

Conversation

story645 commented Sep 15, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

changed the note about reversing a colormap into a section of the colormap reference 'cause it was kind of buried in the preamble

PR Checklist

Tests and Styling

  • [N/A] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

timhoffm reviewed Sep 16, 2022
View reviewed changes
Comment thread examples/color/colormap_reference.py Outdated
tacaswell reviewed Sep 16, 2022
View reviewed changes
Comment thread examples/color/colormap_reference.py Outdated

story645 commented Sep 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

it's very possibly on the verbose side now, but changed the reversed section in the reference to show viridis, cleaned up language, and linked out to a new reversing section in the colormap tutorial that has a cmap.reversed() example

story645 force-pushed the color branch 2 times, most recently from e6b44f6 to 46af8cb Compare September 19, 2022 02:31
timhoffm reviewed Sep 19, 2022
View reviewed changes
Comment thread examples/color/colormap_reference.py Outdated
Comment thread tutorials/colors/colormap-manipulation.py Outdated
timhoffm reviewed Sep 19, 2022
View reviewed changes
Comment thread tutorials/colors/colormap-manipulation.py Outdated
Comment thread tutorials/colors/colormap-manipulation.py Outdated
Comment thread tutorials/colors/colormap-manipulation.py Outdated
story645 force-pushed the color branch 2 times, most recently from 0d7e51e to 284d9e2 Compare September 20, 2022 00:28
timhoffm reviewed Sep 20, 2022
View reviewed changes
Comment thread tutorials/colors/colormap-manipulation.py Outdated
Comment thread tutorials/colors/colormap-manipulation.py
Comment thread tutorials/colors/colormap-manipulation.py Outdated
story645 force-pushed the color branch 2 times, most recently from b238db5 to ce3e284 Compare September 20, 2022 03:50
timhoffm reviewed Sep 20, 2022
View reviewed changes
Comment thread lib/matplotlib/colors.py Outdated
added a reversed section to colormap reference
4552e54 
reversing + registering section to colormap tutorial
removed parent notation from `reversed` methods b/c no heirarchy

Co-authored-by: RutgerK <2157033+RutgerK@users.noreply.github.com>
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Co-authored-by: Jody Klymak <jklymak@gmail.com>
Co-authored-by: Thomas A Caswell <tcaswell@gmail.com>
timhoffm merged commit 3637134 into matplotlib:main Sep 24, 2022
QuLogic added this to the v3.7.0 milestone Sep 24, 2022

story645 commented Sep 25, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

@QuLogic these are all doc changes so shouldn't the milestone be v3.6.1/why is it 3.7.0?

jklymak modified the milestones: v3.7.0, v3.6-doc Sep 25, 2022

timhoffm commented Sep 25, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

@meeseeksdev backport to v3.6.x

This is not v3.6-doc because it contains changes to files inlib (that it‘s only docstrings there does not matter).

timhoffm modified the milestones: v3.6-doc, v3.6.1 Sep 25, 2022

QuLogic commented Sep 26, 2022

Copy link
Copy Markdown
Member

@QuLogic these are all doc changes so shouldn't the milestone be v3.6.1/why is it 3.7.0?

I only document what has occurred in merged PRs.

story645 commented Sep 28, 2022

Copy link
Copy Markdown
Member Author

I only document what has occurred in merged PRs.

So you set the milestone as 3.7.0 b/c it was merged into main?, and this would have to be backported and then changed to 3.6.1?

story645 commented Sep 28, 2022

Copy link
Copy Markdown
Member Author

@meeseeksdev backport to v3.6.1

lumberbot-app Bot commented Sep 28, 2022

Copy link
Copy Markdown

Something went wrong ... Please have a look at my logs.

It seems that the branch you are trying to backport to does not exist.

story645 commented Sep 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

oops, 3.6.1 doesn't exist yet 🤦‍♀️

timhoffm commented Sep 28, 2022

Copy link
Copy Markdown
Member

@meeseeksdev backport to v3.6.x

meeseeksmachine mentioned this pull request Sep 28, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 28, 2022
Backport PR matplotlib#23904: added a reversing section to colormap r…
1d5eff9 
…eference
timhoffm added a commit that referenced this pull request Sep 28, 2022
Merge pull request #24027 from meeseeksmachine/auto-backport-of-pr-23…
cd448d7 
…904-on-v3.6.x

Backport PR #23904 on branch v3.6.x (added a reversing section to colormap reference)
ksunden mentioned this pull request Feb 20, 2023
Merged
6 tasks
story645 deleted the color branch October 12, 2023 16:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tacaswell tacaswell left review comments
jklymak jklymak approved these changes
timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

Documentation topic: color/color & colormaps

Projects

None yet

Milestone

v3.6.1

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL