FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

FIX: ValueError when hexbin is run with empty arrays and log scaling. by erykoff · Pull Request #23944 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

FIX: ValueError when hexbin is run with empty arrays and log scaling. - #23944

Merged
timhoffm merged 3 commits into
matplotlib:mainfrom
erykoff:gh23922
Sep 23, 2022
ConversationCommits (3)ChecksFiles changed
Merged

FIX: ValueError when hexbin is run with empty arrays and log scaling.#23944
timhoffm merged 3 commits into
matplotlib:mainfrom
erykoff:gh23922

Conversation

erykoff commented Sep 19, 2022

Copy link
Copy Markdown
Contributor

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

erykoff commented Sep 19, 2022

Copy link
Copy Markdown
Contributor Author

This PR addresses #23922

github-actions Bot reviewed Sep 19, 2022
View reviewed changes

github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

tacaswell added this to the v3.6.1 milestone Sep 19, 2022
tacaswell reviewed Sep 19, 2022
View reviewed changes
Comment thread lib/matplotlib/colors.py Outdated
self.vmax = A.max()
# Ensure that A has non-zero size to compute min/max.
# Otherwise put in filler values.
if A.size:

tacaswell Sep 19, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is hitting alot of use cases as all of the color mappables to through here, would it be possible to do this check in hexbin instead?

If we do this here, do we want to use the same logic from the auto limit on the Axis to sure min != max (which I forsee causing divide by 0 errors later)?

anntzer reviewed Sep 19, 2022
View reviewed changes
Comment thread lib/matplotlib/colors.py Outdated
self.vmax = A.max()
else:
self.vmin = 0.0
self.vmax = 0.0

anntzer Sep 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Setting these values to zero seems almost certainly wrong; the pre-#21989 behavior was (I think?) to set them to np.ma.masked (I think?) which also seems a bit strange but already better.

erykoff commented Sep 19, 2022

Copy link
Copy Markdown
Contributor Author

Please take a look now. I pushed the fix further upstream and also used masked instead of 0.0. Maybe you have some more elegant ideas; however, this does fix the problem and pass the additional test without touching non-hexbin optimized code paths.

dstansby approved these changes Sep 21, 2022
View reviewed changes

dstansby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me - thanks for the PR!

timhoffm merged commit 0636b9e into matplotlib:main Sep 23, 2022
meeseeksmachine mentioned this pull request Sep 23, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 23, 2022
Backport PR matplotlib#23944: FIX: ValueError when hexbin is run with…
c633956 
… empty arrays and log scaling.

timhoffm commented Sep 23, 2022

Copy link
Copy Markdown
Member

Thanks @erykoff and congratulations on your first contribution to Matplotlib.

QuLogic mentioned this pull request Sep 23, 2022
Closed
QuLogic added a commit that referenced this pull request Sep 23, 2022
Merge pull request #23989 from meeseeksmachine/auto-backport-of-pr-23…
81e7f14 
…944-on-v3.6.x

Backport PR #23944 on branch v3.6.x (FIX: ValueError when hexbin is run with empty arrays and log scaling.)
anntzer mentioned this pull request Oct 23, 2022
Merged
6 tasks
melissawm pushed a commit to melissawm/matplotlib that referenced this pull request Dec 19, 2022
FIX: ValueError when hexbin is run with empty arrays and log scaling. (…
7d14e75 
…matplotlib#23944)

* Add test for empty hexbin with log scaling.

* Use guarded autoscale_None for use when vmin/vmax are None.

* Add additional check when auto vmin/vmax are None.
ksunden mentioned this pull request Feb 20, 2023
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tacaswell tacaswell left review comments
anntzer anntzer left review comments
github-actions[bot] github-actions[bot] left review comments
timhoffm timhoffm approved these changes
dstansby dstansby approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.6.1

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL