FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix building on MINGW by MehdiChinoune · Pull Request #23947 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Fix building on MINGW - #23947

Merged
QuLogic merged 2 commits into
matplotlib:mainfrom
MehdiChinoune:fix-mingw
Sep 19, 2022
ConversationCommits (2)ChecksFiles changed
Merged

Fix building on MINGW#23947
QuLogic merged 2 commits into
matplotlib:mainfrom
MehdiChinoune:fix-mingw

Conversation

MehdiChinoune commented Sep 19, 2022

Copy link
Copy Markdown
Contributor

PR Summary

Fix building matplotlib on MINGW. Recent changes in e1fcc90 broke it.

Fixes #23943

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

github-actions Bot reviewed Sep 19, 2022
View reviewed changes

github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

anntzer reviewed Sep 19, 2022
View reviewed changes
Comment thread src/_tkagg.cpp Outdated

anntzer commented Sep 19, 2022

Copy link
Copy Markdown
Contributor

Seems reasonable now that we require C++11 anyways. Just a minor nit.

anntzer added this to the v3.6.1 milestone Sep 19, 2022
anntzer approved these changes Sep 19, 2022
View reviewed changes

anntzer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Seems reasonable.

QuLogic merged commit 68e5ff9 into matplotlib:main Sep 19, 2022
meeseeksmachine mentioned this pull request Sep 19, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 19, 2022
Backport PR matplotlib#23947: Fix building on MINGW
eac65ff
MehdiChinoune deleted the fix-mingw branch September 19, 2022 20:44
QuLogic added a commit that referenced this pull request Sep 20, 2022
Merge pull request #23960 from meeseeksmachine/auto-backport-of-pr-23…
cf37b76 
…947-on-v3.6.x

Backport PR #23947 on branch v3.6.x (Fix building on MINGW)

tacaswell commented Sep 20, 2022

Copy link
Copy Markdown
Member

Thank you for this fix and congratulations on your first merged Matplotilb PR @MehdiChinoune 🎉

Hopefully we will hear from you again!

ksunden mentioned this pull request Feb 20, 2023
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

github-actions[bot] github-actions[bot] left review comments
QuLogic QuLogic approved these changes
anntzer anntzer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.6.1

Development

Successfully merging this pull request may close these issues.

[Bug]: Couldn't build matplotlib 3.6.0 with both Clang-15 and GCC-12

4 participants

Back | FazBrowse Home | New Git URL