FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

DOC: Display "dev" instead of "devdocs" in the version switcher by timhoffm · Pull Request #23949 · matplotlib/matplotlib · GitHub

Repository navigation

DOC: Display "dev" instead of "devdocs" in the version switcher - #23949

Merged
jklymak merged 1 commit into
matplotlib:mainfrom
timhoffm:version-switcher-dev
Sep 19, 2022
Merged

jklymak merged 1 commit into
matplotlib:mainfrom
timhoffm:version-switcher-dev

Conversation

timhoffm commented Sep 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

This changes to only show "dev".

While the url is devdocs historically, and I'm not going to change this, the displayed names should be "stable" and "dev". This has the added advantage that dev takes a little less space in the menubar, and thus wrapping occurs slightly later.

While the url is devdocs historically, and I'm not going to
change this, the displayed names should be "stable" and "dev".
This has the added advantage that dev takes a little less space
in the menubar, and thus wrapping occurs slightly later.
timhoffm added this to the v3.6-doc milestone Sep 19, 2022

story645 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No idea if this needs 1 or 2 to merge

jklymak merged commit b5fa310 into matplotlib:main Sep 19, 2022

lumberbot-app Bot commented Sep 19, 2022

Copy link
Copy Markdown

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.6.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 b5fa31067e8e67e308b373285a68c44e9ca5efa8
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #23949: DOC: Display "dev" instead of "devdocs" in the version switcher'
  1. Push to a named branch:
git push YOURFORK v3.6.x:auto-backport-of-pr-23949-on-v3.6.x
  1. Create a PR against branch v3.6.x, I would have named this PR:

"Backport PR #23949 on branch v3.6.x (DOC: Display "dev" instead of "devdocs" in the version switcher)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

lumberbot-app Bot commented Sep 19, 2022

Copy link
Copy Markdown

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.6.0-doc
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 b5fa31067e8e67e308b373285a68c44e9ca5efa8
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #23949: DOC: Display "dev" instead of "devdocs" in the version switcher'
  1. Push to a named branch:
git push YOURFORK v3.6.0-doc:auto-backport-of-pr-23949-on-v3.6.0-doc
  1. Create a PR against branch v3.6.0-doc, I would have named this PR:

"Backport PR #23949 on branch v3.6.0-doc (DOC: Display "dev" instead of "devdocs" in the version switcher)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

QuLogic pushed a commit that referenced this pull request Sep 19, 2022
DOC: Display "dev" instead of "devdocs" in the version switcher
(cherry picked from commit b5fa310)

QuLogic commented Sep 19, 2022

Copy link
Copy Markdown
Member

Backported in #23942.

QuLogic modified the milestones: v3.6-doc, v3.6.1 Sep 19, 2022
timhoffm deleted the version-switcher-dev branch September 19, 2022 21:26
melissawm pushed a commit to melissawm/matplotlib that referenced this pull request Dec 19, 2022
DOC: Display "dev" instead of "devdocs" in the version switcher
(cherry picked from commit b5fa310)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL