FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix issue with empty line in ps backend by oscargus · Pull Request #23964 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Fix issue with empty line in ps backend - #23964

Merged
QuLogic merged 1 commit into
matplotlib:mainfrom
oscargus:emprypsline
Sep 24, 2022
ConversationCommits (1)ChecksFiles changed
Merged

Fix issue with empty line in ps backend#23964
QuLogic merged 1 commit into
matplotlib:mainfrom
oscargus:emprypsline

Conversation

oscargus commented Sep 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

Closes #23954

(Identical to #23910 which I forgot existed. This has a test though...)

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).

oscargus added this to the v3.6.1 milestone Sep 20, 2022
oscargus force-pushed the emprypsline branch 2 times, most recently from 4aef735 to 0c53446 Compare September 20, 2022 13:50
oscargus mentioned this pull request Sep 20, 2022
Closed
1 of 2 tasks

tacaswell commented Sep 20, 2022

Copy link
Copy Markdown
Member

Approving your PR is easier than adding a test to mine :)

tacaswell reviewed Sep 20, 2022
View reviewed changes
Comment thread lib/matplotlib/backends/backend_ps.py
# append the last entry
stream.append(curr_stream)
# append the last entry if exists
if curr_stream:

tacaswell Sep 20, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

On consideration, I think the looser check here is better than what I had because I suspect other falsy things (like empty lists) would also break the consumer code.

anntzer reviewed Sep 21, 2022
View reviewed changes
Comment thread lib/matplotlib/tests/test_backend_ps.py Outdated
figure = Figure()
ax = figure.add_subplot(111)
ax.set_title('\nLower title')
ax.annotate(text='\nLower label', xy=(0, 0))

anntzer Sep 21, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Would a figtext (fig.text(...), no axes at all) be enough?

oscargus Sep 23, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It is. I've changed it.

story645 mentioned this pull request Sep 22, 2022
Closed

oscargus commented Sep 23, 2022

Copy link
Copy Markdown
Member Author

Updated the test and seems to have lost the co-authorship from @tacaswell ... Not sure what you changed, but I think that it should be included here (since I pulled the PR to another computer before updating the test).

QuLogic commented Sep 23, 2022

Copy link
Copy Markdown
Member

You can click the commit links on the 'force-pushed' annotation line here. Looks like just a rebase to me.

QuLogic merged commit cada8fb into matplotlib:main Sep 24, 2022
meeseeksmachine mentioned this pull request Sep 24, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 24, 2022
Backport PR matplotlib#23964: Fix issue with empty line in ps backend
0524e4c
oscargus deleted the emprypsline branch September 25, 2022 15:04
oscargus added a commit that referenced this pull request Sep 28, 2022
Merge pull request #23994 from meeseeksmachine/auto-backport-of-pr-23…
5b4b0b3 
…964-on-v3.6.x

Backport PR #23964 on branch v3.6.x (Fix issue with empty line in ps backend)
ksunden mentioned this pull request Feb 20, 2023
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tacaswell tacaswell approved these changes
anntzer anntzer left review comments
dopplershift dopplershift approved these changes

Assignees

No one assigned

Labels

backend: ps

Projects

None yet

Milestone

v3.6.1

Development

Successfully merging this pull request may close these issues.

[Bug]: Text label with empty line causes a "TypeError: cannot unpack non-iterable NoneType object" in PostScript backend

5 participants

Back | FazBrowse Home | New Git URL