FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix wording and links lifecycle tutorial by oscargus · Pull Request #24003 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Fix wording and links lifecycle tutorial - #24003

Merged
timhoffm merged 4 commits into
matplotlib:mainfrom
oscargus:tutorialfix
Sep 26, 2022
ConversationCommits (4)ChecksFiles changed
Merged

Fix wording and links lifecycle tutorial#24003
timhoffm merged 4 commits into
matplotlib:mainfrom
oscargus:tutorialfix

Conversation

oscargus commented Sep 25, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

There was an incorrect sentence that needed rewording. Links added for easier navigation. Add a ,. Replace 1 with one.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

story645 reviewed Sep 25, 2022
View reviewed changes
Comment thread tutorials/introductory/lifecycle.py Outdated
Comment thread tutorials/introductory/lifecycle.py Outdated
Comment thread tutorials/introductory/lifecycle.py Outdated
Apply suggestions from code review
61208b4 
Co-authored-by: hannah <story645@gmail.com>
timhoffm reviewed Sep 25, 2022
View reviewed changes
Comment thread tutorials/introductory/lifecycle.py Outdated
story645 added this to the v3.6-doc milestone Sep 25, 2022
Update tutorials/introductory/lifecycle.py
7bee9ae 
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>

oscargus commented Sep 26, 2022

Copy link
Copy Markdown
Member Author

Please squash-merge...

oscargus commented Sep 26, 2022
View reviewed changes
Comment thread tutorials/introductory/lifecycle.py Outdated
timhoffm merged commit d226954 into matplotlib:main Sep 26, 2022

lumberbot-app Bot commented Sep 26, 2022

Copy link
Copy Markdown

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.6.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 d226954190e4d3299de4b600af0c19763a41edee
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #24003: Fix wording and links lifecycle tutorial'
  1. Push to a named branch:
git push YOURFORK v3.6.x:auto-backport-of-pr-24003-on-v3.6.x
  1. Create a PR against branch v3.6.x, I would have named this PR:

"Backport PR #24003 on branch v3.6.x (Fix wording and links lifecycle tutorial)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

lumberbot-app Bot commented Sep 26, 2022

Copy link
Copy Markdown

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.6.0-doc
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 d226954190e4d3299de4b600af0c19763a41edee
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #24003: Fix wording and links lifecycle tutorial'
  1. Push to a named branch:
git push YOURFORK v3.6.0-doc:auto-backport-of-pr-24003-on-v3.6.0-doc
  1. Create a PR against branch v3.6.0-doc, I would have named this PR:

"Backport PR #24003 on branch v3.6.0-doc (Fix wording and links lifecycle tutorial)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

oscargus deleted the tutorialfix branch September 28, 2022 12:04
rcomer pushed a commit to rcomer/matplotlib that referenced this pull request Dec 10, 2022
Backport PR matplotlib#24003: Fix wording and links lifecycle tutorial
337129e 
Manual backport due to conflict from one-line change in this file at matplotlib#23974.

Co-authored-by: hannah <story645@gmail.com>
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
rcomer mentioned this pull request Dec 10, 2022
Merged
6 tasks

rcomer commented Dec 10, 2022

Copy link
Copy Markdown
Member

@meeseeksdev backport to v3.6.x

meeseeksmachine mentioned this pull request Dec 10, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Dec 10, 2022
Backport PR matplotlib#24003: Fix wording and links lifecycle tutorial
4dfcb45
oscargus added a commit that referenced this pull request Dec 10, 2022
Merge pull request #24686 from rcomer/backport-24003-doc
a22a334 
Backport PR #24003 on branch v3.6.2-doc: Fix wording and links lifecycle tutorial
oscargus added a commit that referenced this pull request Dec 10, 2022
Merge pull request #24687 from meeseeksmachine/auto-backport-of-pr-24…
06c378d 
…003-on-v3.6.x

Backport PR #24003 on branch v3.6.x (Fix wording and links lifecycle tutorial)
melissawm pushed a commit to melissawm/matplotlib that referenced this pull request Dec 19, 2022
Fix wording and links lifecycle tutorial (matplotlib#24003)
548d00b 
* Fix wording and links lifecycle tutorial

* Apply suggestions from code review

Co-authored-by: hannah <story645@gmail.com>

* Update tutorials/introductory/lifecycle.py

Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>

* Update tutorials/introductory/lifecycle.py

Co-authored-by: hannah <story645@gmail.com>
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
ksunden mentioned this pull request Feb 20, 2023
Merged
6 tasks
imgbot Bot pushed a commit to kkipngenokoech/matplotlib that referenced this pull request Apr 19, 2026
Fix wording and links lifecycle tutorial (matplotlib#24003)
6804a32 
* Fix wording and links lifecycle tutorial

* Apply suggestions from code review

Co-authored-by: hannah <story645@gmail.com>

* Update tutorials/introductory/lifecycle.py

Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>

* Update tutorials/introductory/lifecycle.py

Co-authored-by: hannah <story645@gmail.com>
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

timhoffm timhoffm approved these changes
story645 story645 approved these changes

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

v3.6-doc

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL