FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

In usetex, remove vertical space inserted by TeX after displaymath. by anntzer · Pull Request #24011 · matplotlib/matplotlib · GitHub

Repository navigation

In usetex, remove vertical space inserted by TeX after displaymath. - #24011

Draft
anntzer wants to merge 1 commit into
matplotlib:mainfrom
anntzer:dm
Draft

anntzer wants to merge 1 commit into
matplotlib:mainfrom
anntzer:dm

Conversation

anntzer commented Sep 26, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

Closes #23977. One can also check with the simpler example given at #23977 (comment).

Actually in the specific case of the eqnarray given in #23977 there would still seem to be an extra blank line at the bottom, but this is due to the extra \\ at the end of the eqnarray, which is now taken into account (... but not by dvipng apparently (*)); removing it (as shown in documented eqnarray examples, e.g. http://latexref.xyz/eqnarray.html, https://texfaq.org/FAQ-eqnarray) handles that.

(*) but hopefully we'll get rid of dvipng anyways in favor of directly rendering the glyphs ourselves; see e.g. #22459 (comment).

Edit: no, that's not enough if the last line has nonzero descent. Back to the drawing board.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

anntzer added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: text/usetex labels Sep 26, 2022
anntzer added this to the v3.6.1 milestone Sep 26, 2022
anntzer marked this pull request as draft September 26, 2022 09:18

Copy link
Copy Markdown
Member

Off topic: should I file a bug report for dvipng? (The author, coincidentally, is a colleague, currently my boss...)

anntzer commented Sep 26, 2022

Copy link
Copy Markdown
Contributor Author

I don't think it's really a bug in dvipng, just a different definition of "baseline". OTOH one thing that we would look into is to use dvipng --depth... to get the baseline position? But that would require going through dvipng even for the vector backends.

QuLogic commented Sep 27, 2022

Copy link
Copy Markdown
Member

Edit: no, that's not enough if the last line has nonzero descent. Back to the drawing board.

Should we return to the plan of reverting the original PR?

anntzer commented Sep 27, 2022

Copy link
Copy Markdown
Contributor Author

Let's do that for now.

QuLogic modified the milestones: v3.6.1, v3.7.0 Oct 6, 2022

QuLogic commented Oct 6, 2022

Copy link
Copy Markdown
Member

The original PR was reverted, so I assume you'll just put this into 3.7.

anntzer commented Oct 6, 2022

Copy link
Copy Markdown
Contributor Author

Yes.

jklymak removed the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jan 5, 2023
jklymak modified the milestones: v3.7.0, v3.8.0 Jan 5, 2023

jklymak commented Jan 5, 2023

Copy link
Copy Markdown
Member

Moved to 3.8, but feel free to argue for a back port.

anntzer commented Jan 5, 2023

Copy link
Copy Markdown
Contributor Author

No hurries, this still needs some work...

ksunden modified the milestones: v3.8.0, future releases Aug 8, 2023

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Eqnarray in AnchoredText results in misplaced text (new in v3.6.0)

5 participants


Back | FazBrowse Home | New Git URL