FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Reword SpanSelector example. by anntzer · Pull Request #24032 · matplotlib/matplotlib · GitHub

Repository navigation

Reword SpanSelector example. - #24032

Merged
oscargus merged 1 commit into
matplotlib:mainfrom
anntzer:ss
Sep 28, 2022
Merged

oscargus merged 1 commit into
matplotlib:mainfrom
anntzer:ss

Conversation

anntzer commented Sep 28, 2022

Copy link
Copy Markdown
Contributor

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

story645 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

slight word nit, take or leave

Comment thread examples/widgets/span_selector.py Outdated

The SpanSelector is a mouse widget to select a xmin/xmax range and plot the
detail view of the selected region in the lower axes
The `.SpanSelector` is a mouse widget that allows selecting a range on an axis.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
The `.SpanSelector` is a mouse widget that allows selecting a range on an axis.
The `.SpanSelector` is a mouse widget that enables selecting a range on an axis.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

sure

oscargus merged commit 30e257c into matplotlib:main Sep 28, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 28, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 28, 2022
anntzer deleted the ss branch September 28, 2022 17:51
timhoffm added a commit that referenced this pull request Sep 28, 2022
…032-on-v3.6.x

Backport PR #24032 on branch v3.6.x (Reword SpanSelector example.)
QuLogic added a commit that referenced this pull request Sep 28, 2022
…032-on-v3.6.0-doc

Backport PR #24032 on branch v3.6.0-doc (Reword SpanSelector example.)
ksunden mentioned this pull request Feb 20, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL