| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Looks good to me but @anntzer does the pillow stuff need to be commented out? |
Sorry, something went wrong.
|
I actually find this a bit confusing. If the pillow stuff is commented out, why not just add the comments to an existing example |
Sorry, something went wrong.
|
I think seperately I'd really like a simple dot example since the rain scatter has kind of a lot going on in it. |
Sorry, something went wrong.
Sorry, something went wrong.
|
Adding the instructions commented out to a simple preexisting example, e.g. https://matplotlib.org/devdocs/gallery/animation/simple_anim.html, seems fine to me, but an important point is that the title of the example should make it clear that saving as gif is showcased by that example (you don't want the user to click through all animation examples until finding out which one explains how to save as gif). |
Sorry, something went wrong.
Agreed. We can make the title more informative, if we go down the road of using this animation to illustrate saving as a gif. But before I make any changes, awaiting confirmation that we want to do this instead of just adding it to another example. |
Sorry, something went wrong.
|
My bias is that I think this example would be useful and a title like "Scatter Animation Saved as Gif" would keep all the relevant bits. I'm not opposed to adding saving to an existing example instead, but one where a) adding to the title won't detract from the title b)the example isn't so complex that the the saving will get buried. |
Sorry, something went wrong.
Sorry, something went wrong.
|
Sorry, I don't have the bandwidth to look more into this right now. |
Sorry, something went wrong.
|
I'll approve if you change the title to "Animated Scatter Saved as Gif" but I don't know if anyone else will (though I don't think that's a blocker unless somebody explicitly blocks). |
Sorry, something went wrong.
|
Done |
Sorry, something went wrong.
|
We use sentence case, not title case, don't we? ➡ "Animated scatter saved as GIF" (but either way GIF should be capitalized as an acronym.) |
Sorry, something went wrong.
|
🤦♀️yeah, sorry forgot! @kostyafarber please switch to sentence case. |
Sorry, something went wrong.
|
@kostyafarber let me know if I should merge and then a follow up is making this the saving all the things example or if you'll update this as a saving all the things example. |
Sorry, something went wrong.
|
Hey let's just merge it and we can do a follow up PR. Thanks |
Sorry, something went wrong.
…t to the example documentation
|
Something went wrong ... Please have a look at my logs. It seems that the branch you are trying to backport to does not exist. |
Sorry, something went wrong.
…096-on-v3.6.x Backport PR #24096 on branch v3.6.x ([DOC]: Add simple animation scatter plot to the example documentation)
…matplotlib#24096) * add simple animation scatter plot * change title to Animated Scatter Saved as Gif * change title to sentence case
…matplotlib#24096) * add simple animation scatter plot * change title to Animated Scatter Saved as Gif * change title to sentence case
…matplotlib#24096) * add simple animation scatter plot * change title to Animated Scatter Saved as Gif * change title to sentence case
| Back | FazBrowse Home | New Git URL |
PR Summary
This example comes off the back of #22374, the purpose being to provide a simple example of how to use PillowWriter to save an animation as a gif.
PR Checklist
Tests and Styling
Documentation