Repository navigation
Fix mask lookup in fill_between for NumPy 1.24+ - #24115
Merged
timhoffm merged 1 commit intoOct 7, 2022
Merged
timhoffm merged 1 commit into
timhoffm merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
oscargus
approved these changes
Oct 7, 2022
Copy link
Copy Markdown
Member
|
Semi-related: there are still uses of getmask in other parts of the code. Would it be worthwhile revisiting those and replace with getmaskarray? I assume that most of the time we do want an array and that many of those may break with the "wrong" input data? |
Sorry, something went wrong.
timhoffm
approved these changes
Oct 7, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 7, 2022
Copy link
Copy Markdown
Member
Author
|
Possibly, but none of them triggered a test failure with latest NumPy wheels, other than this one. |
Sorry, something went wrong.
6 tasks
QuLogic
added a commit
that referenced
this pull request
Oct 7, 2022
…115-on-v3.6.x Backport PR #24115 on branch v3.6.x (Fix mask lookup in fill_between for NumPy 1.24+)
This was referenced Oct 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
I did not bother adding any new tests, as the existing tests will already break with the latest nightly NumPy wheels.
Fixes #24106
PR Checklist
Tests and Styling
Documentation