FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

DOC: align contour parameter doc with implementation by martok · Pull Request #24130 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

DOC: align contour parameter doc with implementation - #24130

Merged
timhoffm merged 1 commit into
matplotlib:mainfrom
martok:doc-contour-levels
Oct 9, 2022
ConversationCommits (1)ChecksFiles changed
Merged

DOC: align contour parameter doc with implementation#24130
timhoffm merged 1 commit into
matplotlib:mainfrom
martok:doc-contour-levels

Conversation

martok commented Oct 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

Issue #24121.

The docstrings implied a functionality that does not exist and never has, this PR updates to what actually happens.

PR Checklist

Tests and Styling

  • [N/A] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

github-actions Bot reviewed Oct 8, 2022
View reviewed changes

github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

oscargus approved these changes Oct 8, 2022
View reviewed changes

oscargus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good, thanks! I'll wait for someone else to double check that it is indeed as we both think.

oscargus added this to the v3.6.2 milestone Oct 8, 2022
timhoffm merged commit 834c89c into matplotlib:main Oct 9, 2022
meeseeksmachine mentioned this pull request Oct 9, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 9, 2022
Backport PR matplotlib#24130: DOC: align contour parameter doc with i…
a6bcc0a 
…mplementation

timhoffm commented Oct 9, 2022

Copy link
Copy Markdown
Member

Thanks @martok, and congratulations on your first contribution to Matplotlib. We’d be happy to see you back.

timhoffm mentioned this pull request Oct 9, 2022
Closed
oscargus added a commit that referenced this pull request Oct 10, 2022
Merge pull request #24134 from meeseeksmachine/auto-backport-of-pr-24…
4c594b2 
…130-on-v3.6.x

Backport PR #24130 on branch v3.6.x (DOC: align contour parameter doc with implementation)
ksunden mentioned this pull request Feb 20, 2023
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

github-actions[bot] github-actions[bot] left review comments
timhoffm timhoffm approved these changes
oscargus oscargus approved these changes

Assignees

No one assigned

Labels

Documentation topic: contour topic: tri

Projects

None yet

Milestone

v3.6.2

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL