FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix argument order in hist() docstring. by carschno · Pull Request #24164 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Fix argument order in hist() docstring. - #24164

Merged
story645 merged 1 commit into
matplotlib:mainfrom
carschno:fix_hist_docstring
Oct 14, 2022
ConversationCommits (1)ChecksFiles changed
Merged

Fix argument order in hist() docstring.#24164
story645 merged 1 commit into
matplotlib:mainfrom
carschno:fix_hist_docstring

Conversation

carschno commented Oct 14, 2022

Copy link
Copy Markdown
Contributor

PR Summary

In the rendered documentation for the pyplot.hist() method, the arguments for the plt.stairs() call is reversed.

PR Checklist

Tests and Styling

  • [N/A] Has pytest style unit tests (and pytest passes).
  • [N/A] Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

github-actions Bot reviewed Oct 14, 2022
View reviewed changes

github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

story645 approved these changes Oct 14, 2022
View reviewed changes

story645 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks so much for catching this!

story645 modified the milestones: v3.6-doc, v3.6.2 Oct 14, 2022
story645 merged commit 1f9dc78 into matplotlib:main Oct 14, 2022
meeseeksmachine mentioned this pull request Oct 14, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 14, 2022
Backport PR matplotlib#24164: Fix argument order in hist() docstring.
2a1958b

story645 commented Oct 14, 2022

Copy link
Copy Markdown
Member

Merged cause the failed tests didn't have anything to do w/ the PR.

Thanks @carschno for fixing the bug I introduced 😓, congrats on your first pr to Matplotlib 🥳, and we hope to see you again!

carschno deleted the fix_hist_docstring branch October 14, 2022 13:54
oscargus added a commit that referenced this pull request Oct 14, 2022
Merge pull request #24165 from meeseeksmachine/auto-backport-of-pr-24…
909269d 
…164-on-v3.6.x

Backport PR #24164 on branch v3.6.x (Fix argument order in hist() docstring.)
ksunden mentioned this pull request Feb 20, 2023
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

github-actions[bot] github-actions[bot] left review comments
story645 story645 approved these changes

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

v3.6.2

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL