FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add tests for ToolManager by oscargus · Pull Request #24184 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Add tests for ToolManager - #24184

Merged
QuLogic merged 1 commit into
matplotlib:mainfrom
oscargus:testbackendmanager
Oct 19, 2022
ConversationCommits (1)ChecksFiles changed
Merged

Add tests for ToolManager#24184
QuLogic merged 1 commit into
matplotlib:mainfrom
oscargus:testbackendmanager

Conversation

oscargus commented Oct 15, 2022

Copy link
Copy Markdown
Member

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

timhoffm reviewed Oct 15, 2022
View reviewed changes
Comment thread lib/matplotlib/tests/test_backend_bases.py Outdated
QuLogic reviewed Oct 17, 2022
View reviewed changes
Comment thread lib/matplotlib/tests/test_backend_bases.py Outdated
Comment thread lib/matplotlib/tests/test_backend_bases.py Outdated
Comment thread lib/matplotlib/tests/test_backend_bases.py Outdated
timhoffm approved these changes Oct 18, 2022
View reviewed changes

timhoffm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Approved, provided @QuLogic comments are handled.

QuLogic merged commit 2770b45 into matplotlib:main Oct 19, 2022
oscargus deleted the testbackendmanager branch October 19, 2022 07:54
QuLogic added this to the v3.6.2 milestone Oct 20, 2022

QuLogic commented Oct 20, 2022

Copy link
Copy Markdown
Member

Forgot about the milestone.

@meeseeksdev backport to v3.6.x

meeseeksmachine mentioned this pull request Oct 20, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 20, 2022
Backport PR matplotlib#24184: Add tests for ToolManager
cddc066
timhoffm added a commit that referenced this pull request Oct 20, 2022
Merge pull request #24223 from meeseeksmachine/auto-backport-of-pr-24…
0671809 
…184-on-v3.6.x

Backport PR #24184 on branch v3.6.x (Add tests for ToolManager)
ksunden mentioned this pull request Feb 20, 2023
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

QuLogic QuLogic approved these changes
timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

topic: testing

Projects

None yet

Milestone

v3.6.2

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL