Repository navigation
Update example and docstring to encourage the use of functools.partial in FuncAnimation - #24238
Merged
ksunden merged 4 commits intoNov 1, 2022
Merged
ksunden merged 4 commits into
ksunden merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
anntzer
reviewed
Oct 21, 2022
Comment thread
doc/api/animation_api.rst
Outdated
tacaswell
reviewed
Oct 21, 2022
Comment thread
doc/api/animation_api.rst
Outdated
tacaswell
reviewed
Oct 21, 2022
Comment thread
doc/api/animation_api.rst
Outdated
tacaswell
reviewed
Oct 21, 2022
Comment thread
doc/api/animation_api.rst
Outdated
tacaswell
reviewed
Oct 21, 2022
Comment thread
lib/matplotlib/animation.py
Outdated
tacaswell
reviewed
Oct 21, 2022
Comment thread
lib/matplotlib/animation.py
Outdated
Copy link
Copy Markdown
Member
|
I would prefer to show passing the artist in via the partial rather than the data. The goal is to be able to write (or import) your update function in a way that does not require it to be able to capture the artist to be updated in the closure. |
Sorry, something went wrong.
Co-authored-by: Thomas A Caswell <tcaswell@gmail.com>
Copy link
Copy Markdown
Member
Author
|
Am I right in believing that the example is now doing that? (I fixed a few things to make it work...) |
Sorry, something went wrong.
QuLogic
approved these changes
Oct 26, 2022
Comment thread
doc/api/animation_api.rst
Outdated
ksunden
reviewed
Oct 26, 2022
Comment thread
doc/api/animation_api.rst
Outdated
Copy link
Copy Markdown
Member
Author
|
Can someone please have a final look at this? |
Sorry, something went wrong.
ksunden
approved these changes
Nov 1, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 1, 2022
…ge the use of functools.partial in FuncAnimation
timhoffm
added a commit
that referenced
this pull request
Nov 1, 2022
…238-on-v3.6.x Backport PR #24238 on branch v3.6.x (Update example and docstring to encourage the use of functools.partial in FuncAnimation)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #20326
Closes #20358
Closes #24139
Merged contents from #20358 and #24139 with comments. Probably have missed something...
PR Checklist
Tests and Styling
Documentation