| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
voxels does not use cmap at all, and thus does not modify shade in relation to cmap being passed in, this appears to be copy/pasted from methods which _do_ use cmap
|
It does not fall through to the underlying PolyCollection3D? |
Sorry, something went wrong.
Sorry, something went wrong.
|
@tacaswell Poly3DCollection makes no references to cmaps whatsoever, relying on the higher level functions to call the map to get facecolors. In fact the light source shading itself is even done in voxels as well. The data for voxels is fundamentally binary (show this voxel or don't) and so don't map onto a cmap. Granted, the cmap kwarg is passed down the chain all the way to Collection and it is not an exception to pass one, but there is not data to evaluate that cmap at. voxels does not accept a c or colors argument (though that may be a reasonable addition which would make the handling described by the current docstring necessary) For reference, I noticed this while looking into #24277, where the reporter is requesting pretty much exactly that. its easy enough to work around with the tools provided, and bringing in norms and all of the color-focused arguments may be more effort than we wish. |
Sorry, something went wrong.
|
This is another candidate for remove_method? |
Sorry, something went wrong.
…284-on-v3.6.x Backport PR #24284 on branch v3.6.x (Remove comment about cmap from voxels docstring)
| Back | FazBrowse Home | New Git URL |
PR Summary
voxels does not use cmap at all, and thus does not modify shade in relation to cmap being passed in, this appears to be copy/pasted from 3D methods which do use cmap.
PR Checklist
Tests and Styling
Documentation
Release Notes