Repository navigation
Restore get_renderer function in deprecated tight_layout - #24301
Merged
QuLogic merged 1 commit intoNov 2, 2022
Merged
QuLogic merged 1 commit into
QuLogic merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
oscargus
marked this pull request as ready for review
October 29, 2022 10:52
oscargus
force-pushed
the
restoregetrenderer
branch
from
1fe0a1f to
2602b90
Compare
October 29, 2022 10:53
anntzer
reviewed
Oct 29, 2022
Comment thread
lib/matplotlib/_tight_layout.py
Outdated
timhoffm
reviewed
Oct 29, 2022
timhoffm
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Maybe better restore the method to the non-private module?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
You are both right. I was, incorrectly, under the impression that the module would be removed once the deprecation expires. Thanks for thinking! |
Sorry, something went wrong.
oscargus
force-pushed
the
restoregetrenderer
branch
from
2602b90 to
2f49642
Compare
October 30, 2022 12:37
timhoffm
approved these changes
Oct 30, 2022
jklymak
reviewed
Oct 30, 2022
Comment thread
lib/matplotlib/tight_layout.py
Outdated
oscargus
force-pushed
the
restoregetrenderer
branch
from
2f49642 to
62bea32
Compare
October 31, 2022 08:51
jklymak
reviewed
Oct 31, 2022
Comment thread
lib/matplotlib/tight_layout.py
jklymak
approved these changes
Oct 31, 2022
QuLogic
requested changes
Oct 31, 2022
Comment thread
lib/matplotlib/tight_layout.py
Outdated
oscargus
force-pushed
the
restoregetrenderer
branch
from
62bea32 to
8faef77
Compare
November 1, 2022 10:03
QuLogic
approved these changes
Nov 2, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 2, 2022
…ated tight_layout
QuLogic
added a commit
that referenced
this pull request
Nov 2, 2022
…301-on-v3.6.x Backport PR #24301 on branch v3.6.x (Restore get_renderer function in deprecated tight_layout)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
get_renderer was removed in #22745 despite being a public (listed) function, see #24300 (comment)
Closes #24300
PR Checklist
Tests and Styling
Documentation
Release Notes