Repository navigation
Minor improvements to Annotations Tutorial - #24314
Merged
timhoffm merged 1 commit intoNov 1, 2022
Merged
timhoffm merged 1 commit into
timhoffm merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
timhoffm
force-pushed
the
doc-annotation-tutorial
branch
from
c19b99c to
d69fc98
Compare
October 30, 2022 23:32
story645
reviewed
Oct 30, 2022
Comment thread
tutorials/text/annotations.py
Outdated
Comment thread
tutorials/text/annotations.py
Outdated
Copy link
Copy Markdown
Member
|
Like the new position & actually having an intro better 😅 |
Sorry, something went wrong.
timhoffm
force-pushed
the
doc-annotation-tutorial
branch
from
d69fc98 to
ba03e48
Compare
November 1, 2022 12:03
Copy link
Copy Markdown
Member
Author
|
@story645 @jklymak I've just taken over the suggestions. I'm not up to fine-tuning the semantics of "annotation" or whether or not text() is an option for simple annotations. Please do that in follow-up PRs, or speak up to take over this PR push further improvements. |
Sorry, something went wrong.
story645
reviewed
Nov 1, 2022
Comment thread
tutorials/text/annotations.py
Outdated
timhoffm
force-pushed
the
doc-annotation-tutorial
branch
from
ba03e48 to
784297d
Compare
November 1, 2022 16:22
story645
approved these changes
Nov 1, 2022
story645
reviewed
Nov 1, 2022
Comment thread
tutorials/text/annotations.py
Outdated
story645
approved these changes
Nov 1, 2022
- Move the basic text() vs. annotate() discussion to the top - Styling in "Annotating with boxed text": move the text from Axes edge to center; less glaring colors Co-authored-by: hannah <story645@gmail.com>
timhoffm
force-pushed
the
doc-annotation-tutorial
branch
from
784297d to
484e380
Compare
November 1, 2022 20:53
Copy link
Copy Markdown
Member
Author
|
I self-merge based on @story645's approval. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #23606.
There's still more that can be done in later PRs ...