Repository navigation
DOC: clarify rc_context resets all rcParams changes - #24354
Merged
timhoffm merged 1 commit intoNov 3, 2022
Merged
timhoffm merged 1 commit into
timhoffm merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
timhoffm
approved these changes
Nov 3, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 3, 2022
oscargus
added a commit
that referenced
this pull request
Nov 3, 2022
…354-on-v3.6.x Backport PR #24354 on branch v3.6.x (DOC: clarify rc_context resets all rcParams changes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Inspired by #24351
Reading the docstring of rc_context it was very unclear that all rcparams set in the body will be reset not just those set in the context invocation. This has been the behavior back to 2012 when we added this to the code base in 2045bdb .