FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

DOC: Fix syntax of suggestion by larsoner · Pull Request #24363 · matplotlib/matplotlib · GitHub

Repository navigation

DOC: Fix syntax of suggestion - #24363

Merged
tacaswell merged 1 commit into
matplotlib:mainfrom
larsoner:doc
Nov 4, 2022
Merged

tacaswell merged 1 commit into
matplotlib:mainfrom
larsoner:doc

Conversation

larsoner commented Nov 4, 2022

Copy link
Copy Markdown
Contributor

PR Summary

PR Checklist

Documentation

  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

I blindly copy-pasted the suggested code and got:

SyntaxError: positional argument follows keyword argument

I changed it to use positional-only, but I could change them all to be kwargs instead if you want.

tacaswell added this to the v3.6.3 milestone Nov 4, 2022
tacaswell modified the milestones: v3.6.3, v3.6-doc Nov 4, 2022
tacaswell merged commit edaaa3a into matplotlib:main Nov 4, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 4, 2022

Copy link
Copy Markdown
Member

@meeseeksdev backport to v3.6.2-doc

lumberbot-app Bot commented Nov 4, 2022

Copy link
Copy Markdown

Something went wrong ... Please have a look at my logs.

It seems that the branch you are trying to backport to does not exist.

tacaswell modified the milestones: v3.6-doc, v3.6.3 Nov 4, 2022
timhoffm added a commit that referenced this pull request Nov 4, 2022
…363-on-v3.6.x

Backport PR #24363 on branch v3.6.x (DOC: Fix syntax of suggestion)

QuLogic commented Nov 4, 2022

Copy link
Copy Markdown
Member

meeseeksdev backport to v3.6.2-doc

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 4, 2022
QuLogic modified the milestones: v3.6.3, v3.6-doc Nov 4, 2022
timhoffm added a commit that referenced this pull request Nov 4, 2022
…363-on-v3.6.2-doc

Backport PR #24363 on branch v3.6.2-doc (DOC: Fix syntax of suggestion)
ksunden mentioned this pull request Feb 20, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL