Repository navigation
Makefile html-noplot,clean: constrained layout tutorial image handling - #24445
Merged
tacaswell merged 1 commit intoFeb 1, 2023
Merged
tacaswell merged 1 commit into
tacaswell merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
rcomer
force-pushed
the
noplot-warning
branch
from
8598bb6 to
5d2bcd8
Compare
November 13, 2022 14:28
Copy link
Copy Markdown
Member
Author
|
Updated so that these images get tidied by make clean. Perhaps my previous reliance on make clean is why I didn't see these warnings last time. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Constrained layout needs to show the difference between bbox_inches='tight' and not calling that, so it saves the image and then links it. We could just commit the image, but if things change, someone would have to remember to regenerate it. This seemed easiest. Alternates five years ago were non-trivial: sphinx-gallery/sphinx-gallery#726 |
Sorry, something went wrong.
jklymak
approved these changes
Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Follow up to #23870. It seems I somehow missed a couple of warnings that are thrown when running make html-noplot. Perhaps my branch was not fully up-to-date.
My current change is very specific to the constrained layout tutorial, but it looks like the image handling in the constrained layout tutorial is very specific to issues encountered there: #22289 (comment), sphinx-gallery/sphinx-gallery#726.
PR Checklist
Tests and Styling
Documentation
Release Notes