FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix floating-point drift in oscilloscope example by QuLogic · Pull Request #24481 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Fix floating-point drift in oscilloscope example - #24481

Merged
tacaswell merged 1 commit into
matplotlib:mainfrom
QuLogic:fix-oscilloscope-drift
Nov 17, 2022
ConversationCommits (1)ChecksFiles changed
Merged

Fix floating-point drift in oscilloscope example#24481
tacaswell merged 1 commit into
matplotlib:mainfrom
QuLogic:fix-oscilloscope-drift

Conversation

QuLogic commented Nov 17, 2022

Copy link
Copy Markdown
Member

PR Summary

I left this running to about 3500s and it had not drifted out of the 2s interval.

Fixes #24476

PR Checklist

Documentation and Tests

  • [n/a] Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] New plotting related features are documented with examples.

Release Notes

  • [n/a] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [n/a] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • [n/a] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

QuLogic added this to the v3.6.3 milestone Nov 17, 2022
oscargus approved these changes Nov 17, 2022
View reviewed changes

oscargus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good!

Not merging as I thought this should go in 3.6-doc? But feel free to self merge as I trust your decision. (I thought I had finally understood the backport aspects...)

"Documentation changes (all .rst files and examples) are milestoned v3.N-doc."

oscargus commented Nov 17, 2022

Copy link
Copy Markdown
Member

(I guess that there can still be some drift in particular cases, but this is for sure better than the previous version and it is also good that the default setting does not drift.)

tacaswell merged commit 8b4bee7 into matplotlib:main Nov 17, 2022
meeseeksmachine mentioned this pull request Nov 17, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 17, 2022
Backport PR matplotlib#24481: Fix floating-point drift in oscilloscop…
1c202a4 
…e example
oscargus added a commit that referenced this pull request Nov 17, 2022
Merge pull request #24485 from meeseeksmachine/auto-backport-of-pr-24…
0a42fe9 
…481-on-v3.6.x

Backport PR #24481 on branch v3.6.x (Fix floating-point drift in oscilloscope example)
QuLogic deleted the fix-oscilloscope-drift branch November 18, 2022 00:07

QuLogic commented Nov 18, 2022

Copy link
Copy Markdown
Member Author

You're right it can go to doc as well.

meeseeksdev backport to v3.6.x-doc

lumberbot-app Bot commented Nov 18, 2022

Copy link
Copy Markdown

Something went wrong ... Please have a look at my logs.

It seems that the branch you are trying to backport to does not exist.

QuLogic commented Nov 18, 2022

Copy link
Copy Markdown
Member Author

Oops...

meeseeksdev backport to v3.6.2-doc

meeseeksmachine mentioned this pull request Nov 18, 2022
Merged
QuLogic modified the milestones: v3.6.3, v3.6-doc Nov 18, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 18, 2022
Backport PR matplotlib#24481: Fix floating-point drift in oscilloscop…
5a31a8e 
…e example
ksunden added a commit that referenced this pull request Nov 18, 2022
Merge pull request #24492 from meeseeksmachine/auto-backport-of-pr-24…
b4e549b 
…481-on-v3.6.2-doc

Backport PR #24481 on branch v3.6.2-doc (Fix floating-point drift in oscilloscope example)
ksunden mentioned this pull request Feb 20, 2023
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

oscargus oscargus approved these changes

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

v3.6-doc

Development

Successfully merging this pull request may close these issues.

[Doc]: Oscilloscope demo x-axis offset

3 participants

Back | FazBrowse Home | New Git URL