FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use relative frame path in HTMLWriter by QuLogic · Pull Request #24482 · matplotlib/matplotlib · GitHub

Repository navigation

Use relative frame path in HTMLWriter - #24482

Merged
ksunden merged 1 commit into
matplotlib:mainfrom
QuLogic:html-relative-frames
Nov 19, 2022
Merged

ksunden merged 1 commit into
matplotlib:mainfrom
QuLogic:html-relative-frames

Conversation

QuLogic commented Nov 17, 2022

Copy link
Copy Markdown
Member

PR Summary

I don't know about testing this, but I did check that it works correctly if you save to an absolute path or to a relative path above the current directory.

Fixes #23581

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] New plotting related features are documented with examples.

Release Notes

  • [n/a] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [n/a] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • [n/a] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

tacaswell added this to the v3.6.3 milestone Nov 18, 2022

ksunden commented Nov 19, 2022

Copy link
Copy Markdown
Member

CircleCI failure is unrelated to this change (#24488)

ksunden merged commit dc7b4f2 into matplotlib:main Nov 19, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 19, 2022
QuLogic deleted the html-relative-frames branch November 19, 2022 02:15
tacaswell added a commit that referenced this pull request Nov 19, 2022
…482-on-v3.6.x

Backport PR #24482 on branch v3.6.x (Use relative frame path in HTMLWriter)
ksunden mentioned this pull request Feb 20, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: frame paths relative to the html file when saving an animation to html

3 participants


Back | FazBrowse Home | New Git URL