FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

DOC: improved the doc for layout_engine.py by ramvikrams · Pull Request #24548 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

DOC: improved the doc for layout_engine.py - #24548

Merged
story645 merged 2 commits into
matplotlib:mainfrom
ramvikrams:t2
Nov 26, 2022
ConversationCommits (2)ChecksFiles changed
Merged

DOC: improved the doc for layout_engine.py#24548
story645 merged 2 commits into
matplotlib:mainfrom
ramvikrams:t2

Conversation

ramvikrams commented Nov 26, 2022

Copy link
Copy Markdown
Contributor

PR Summary

closes #24518
changed the doc as specified in the issue

PR Checklist

Documentation and Tests

  • [N/A ] Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [ N/A] New plotting related features are documented with examples.

Release Notes

  • [ N/A] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [ N/A] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • [ N/A] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

jklymak approved these changes Nov 26, 2022
View reviewed changes

jklymak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for putting this in. Though maybe I shouldn't be the final review...

story645 added this to the v3.6-doc milestone Nov 26, 2022
story645 merged commit fbfa28d into matplotlib:main Nov 26, 2022
meeseeksmachine mentioned this pull request Nov 26, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 26, 2022
Backport PR matplotlib#24548: DOC: improved the doc for layout_engine.py
93a6d45
meeseeksmachine mentioned this pull request Nov 26, 2022
Closed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 26, 2022
Backport PR matplotlib#24548: DOC: improved the doc for layout_engine.py
db15b36

story645 commented Nov 26, 2022

Copy link
Copy Markdown
Member

Congrats on your first PR 🥳 & thanks for putting in this change! We hope to see you again 😁

ramvikrams commented Nov 26, 2022

Copy link
Copy Markdown
Contributor Author

Congrats on your first PR 🥳 & thanks for putting in this change! We hope to see you again 😁

Thanks for your kind reply, I also wish to contribute to matplotlib frequently

timhoffm added a commit that referenced this pull request Nov 27, 2022
Merge pull request #24551 from meeseeksmachine/auto-backport-of-pr-24…
e509e40 
…548-on-v3.6.x

Backport PR #24548 on branch v3.6.x (DOC: improved the doc for layout_engine.py)
tacaswell mentioned this pull request Nov 28, 2022
Closed
1 task done
QuLogic modified the milestones: v3.6-doc, v3.6.3 Nov 29, 2022
ksunden mentioned this pull request Feb 20, 2023
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

story645 story645 approved these changes
jklymak jklymak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.6.3

Development

Successfully merging this pull request may close these issues.

[Doc]: layout_engine description

4 participants

Back | FazBrowse Home | New Git URL