FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix: Gracefully fail the string validator for tuple inputs by iofall · Pull Request #24600 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Fix: Gracefully fail the string validator for tuple inputs - #24600

Merged
tacaswell merged 1 commit into
matplotlib:mainfrom
iofall:rcparams-legend-loc
Dec 3, 2022
ConversationCommits (1)ChecksFiles changed
Merged

Fix: Gracefully fail the string validator for tuple inputs#24600
tacaswell merged 1 commit into
matplotlib:mainfrom
iofall:rcparams-legend-loc

Conversation

iofall commented Dec 3, 2022

Copy link
Copy Markdown
Contributor

Partially closes - #22338

PR Summary

Gracefully fail the string validator when tuple values are provided to rcParams. Addresses the first part of the issue.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

tacaswell added this to the v3.6.3 milestone Dec 3, 2022
github-actions Bot reviewed Dec 3, 2022
View reviewed changes

github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

tacaswell merged commit ab7917a into matplotlib:main Dec 3, 2022
meeseeksmachine mentioned this pull request Dec 3, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Dec 3, 2022
Backport PR matplotlib#24600: Fix: Gracefully fail the string validat…
149ab12 
…or for tuple inputs

tacaswell commented Dec 3, 2022

Copy link
Copy Markdown
Member

Thank you @iofall and congratulations on your first merged Matplotlib PR 🎉

It was great to work with you at the sprint and I hope we hear from you again!

oscargus added a commit that referenced this pull request Dec 4, 2022
Merge pull request #24601 from meeseeksmachine/auto-backport-of-pr-24…
1188b83 
…600-on-v3.6.x

Backport PR #24600 on branch v3.6.x (Fix: Gracefully fail the string validator for tuple inputs)
ksunden mentioned this pull request Feb 20, 2023
Merged
6 tasks
oscargus mentioned this pull request May 5, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

github-actions[bot] github-actions[bot] left review comments
tacaswell tacaswell approved these changes
oscargus oscargus approved these changes

Assignees

No one assigned

Labels

topic: rcparams

Projects

None yet

Milestone

v3.6.3

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL