FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Addresses issue #24617 adding setters/getters for Figure by garveyz2 · Pull Request #24696 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Addresses issue #24617 adding setters/getters for Figure - #24696

Closed
garveyz2 wants to merge 4 commits into
matplotlib:mainfrom
garveyz2:setters-getters
ConversationCommits (4)ChecksFiles changed
Closed

Addresses issue #24617 adding setters/getters for Figure#24696
garveyz2 wants to merge 4 commits into
matplotlib:mainfrom
garveyz2:setters-getters

Conversation

garveyz2 commented Dec 11, 2022

Copy link
Copy Markdown

PR Summary

Hello, this is my first contribution to an open-source project. This PR is to address the concerns raised in #24617. I've cherrypicked my solution from a previous PR #21549. I have mainly added setters and getters for subplot params as well as modifying the aliases for size_inches to figsize and layout_engine to layout.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

garveyz2 marked this pull request as draft December 11, 2022 23:35
github-actions Bot reviewed Dec 11, 2022
View reviewed changes

github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

rcomer commented Jan 13, 2023

Copy link
Copy Markdown
Member

@garveyz2 thanks for your work on this. Is it ready to be reviewed? If so you should see a "Ready for review" button which will take the "draft" status off it.

rcomer linked an issue Jan 13, 2023 that may be closed by this pull request
[ENH]: Add setter/getter methods for all keyword parameters to Figure.__init__ #24617
Open
pmeier mentioned this pull request Jan 17, 2023
Closed
tacaswell mentioned this pull request May 5, 2023
Open

NoyHanan commented May 6, 2023

Copy link
Copy Markdown
Contributor

Hi @rcomer,
I would like to take over this pr, can you please give me permissions?
Thanks!

rcomer commented May 6, 2023

Copy link
Copy Markdown
Member

Thank you @NoyHanan. Please create a new branch and a new PR referencing this one. You could git cherry-pick the commits from here into your branch or write something new, whichever you prefer.

dutta712 mentioned this pull request May 24, 2023
Open

tacaswell commented Nov 2, 2023

Copy link
Copy Markdown
Member

I am going to close this PR as abandoned.

Thank you for your effort @garveyz2 I do hope we hear from you again.

tacaswell closed this Nov 2, 2023
melissawm moved this from Waiting for author to Done in First Time Contributors Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

github-actions[bot] github-actions[bot] left review comments

Assignees

No one assigned

Labels

status: needs rebase status: orphaned PR status: superseded

Projects

First Time Contributors
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ENH]: Add setter/getter methods for all keyword parameters to Figure.__init__

6 participants

Back | FazBrowse Home | New Git URL