| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
| echo "No deprecation warnings in gallery") | ||
| (grep DeprecationWarning -r -l doc/build/html/tutorials || | ||
| echo "No deprecation warnings in tutorials") | ||
| (grep -rl DeprecationWarning doc/build/html/gallery || |
There was a problem hiding this comment.
is it worth it to add the plot_types gallery or nah 'cause it's super specific?
Sorry, something went wrong.
There was a problem hiding this comment.
I just copied the existing warning checks, but I don't see any reason not to check plot_types as well.
Sorry, something went wrong.
didn't mean to press request changes button
This will fail until the doc build is complete, which causes unwanted notifications about the job 'failing'.
There was a problem hiding this comment.
Looks good! (Although I prefer not to have to rewrite the reviewdog call...)
(I'm not sure I'm a big believer in Review Dog doing a better job* than just posting a comment, but this works nicely and fits the current flow.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
This posts the warnings and deprecations from the doc builds as artifacts, then fetches them from the GitHub Action for CircleCI posting, and posts them as commit checks.
It also removes the URL check that I added in #24579. While it can be fixed, it would still "error" when the build initially starts (because there are no artifacts) and we've lasted without it so far, so I took it out.
Now, I've found out that the status event only triggers for the workflow on the default branch, so the changes here won't be directly reflected until merged (and is why the URL check thing above wasn't noticed before merging). Therefore, I have pushed this change to my fork's main branch, then opened a PR that breaks a reST target and a deprecation in an example. You can see this posting here: https://github.com/QuLogic/matplotlib/pull/25/files
Fixes #22176
PR Checklist
Documentation and Tests
Release Notes