FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Support masked dates by oscargus · Pull Request #24734 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Support masked dates - #24734

Merged
rcomer merged 1 commit into
matplotlib:mainfrom
oscargus:maskeddates
Dec 16, 2022
ConversationCommits (1)ChecksFiles changed
Merged

Support masked dates#24734
rcomer merged 1 commit into
matplotlib:mainfrom
oscargus:maskeddates

Conversation

oscargus commented Dec 15, 2022

Copy link
Copy Markdown
Member

PR Summary

Related to #24732 (comment)

Now, date2num does not strip any mask information.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

oscargus marked this pull request as ready for review December 15, 2022 15:10
oscargus mentioned this pull request Dec 15, 2022
Merged
1 of 6 tasks
chahak13 reviewed Dec 15, 2022
View reviewed changes
Comment thread lib/matplotlib/dates.py Outdated
rcomer reviewed Dec 15, 2022
View reviewed changes
Comment thread lib/matplotlib/dates.py Outdated
Comment thread lib/matplotlib/tests/test_dates.py
oscargus marked this pull request as draft December 15, 2022 16:14
chahak13 reviewed Dec 15, 2022
View reviewed changes
Comment thread lib/matplotlib/dates.py

oscargus commented Dec 15, 2022

Copy link
Copy Markdown
Member Author

Thanks for your good reviews @rcomer and @chahak13 !

I came up with a slightly different solution as astimezone didn't exist for MaskedConstant. Now, both paths are tested using masked dates.

oscargus marked this pull request as ready for review December 15, 2022 20:55
oscargus added this to the v3.7.0 milestone Dec 15, 2022
oscargus mentioned this pull request Dec 15, 2022
Closed
rcomer merged commit 60dd992 into matplotlib:main Dec 16, 2022
oscargus deleted the maskeddates branch December 16, 2022 13:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jklymak jklymak approved these changes
rcomer rcomer approved these changes
+1 more reviewer
chahak13 chahak13 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

topic: date handling topic: units and array ducktypes

Projects

None yet

Milestone

v3.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL