Repository navigation
DOC: fix strip_chart example with numpy 1.24 - #24774
Merged
ksunden merged 1 commit intoDec 19, 2022
Merged
ksunden merged 1 commit into
ksunden merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
oscargus
approved these changes
Dec 19, 2022
oscargus
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Weird change considering the error message. Well hunted!
Sorry, something went wrong.
ksunden
approved these changes
Dec 19, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Dec 19, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Dec 19, 2022
rcomer
added a commit
that referenced
this pull request
Dec 19, 2022
…774-on-v3.6.x Backport PR #24774 on branch v3.6.x (DOC: fix strip_chart example with numpy 1.24)
rcomer
added a commit
that referenced
this pull request
Dec 19, 2022
…774-on-v3.6.2-doc Backport PR #24774 on branch v3.6.2-doc (DOC: fix strip_chart example with numpy 1.24)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
With numpy 1.24 we are ending up with the y-data being passed to the line that looked like
which was then causing issues when we went to convert that list to an array. I did not track down if this is a change in the behavior of np.random.rand or in how picky the list->array casting logic is.
For reasons that are very unclear to me this also unbreaks the unchained example when building the docs which suggests to me that the examples are not as isolated as we think (I could not get the unchained demo to fail outside of the docs build which also suggests some state leakage between them).