Repository navigation
inset locator fix with tests added - #24783
dstansby merged 1 commit into
Conversation
Sorry, something went wrong.
| fig.canvas.draw() | ||
|
|
||
|
|
||
| @image_comparison(['anchored_locator_base_call.png'], style="mpl20") |
There was a problem hiding this comment.
| @image_comparison(['anchored_locator_base_call.png'], style="mpl20") | |
| @image_comparison(['anchored_locator_base_call.png'], style="mpl20", remove_text=True) |
Or is the text a crucial part of the appearance?
(It is generally a good idea to remove the text if not needed, plus that it is cropped in this example.)
(A good approach to avoid conflicts is to insert the test at some random location in the file. This is as many insert it at the end and therefore it is more likely that there will be conflicts there. Hopefully this will be merged soon though.)
Sorry, something went wrong.
There was a problem hiding this comment.
@oscargus. Thank you for the feedback. I agree with your comments but i had trouble generating a test image that would pass the image comparison test when remove_text is true. I do agree, however, that the test should be for just the image and not the text. I have resubmitted the test case where I didn't put the "remove_text" but did remove all the text in the test case and generate a test image without any text.
If this isn't quite acceptable, can you provide more details on your proposed approach? Thanks!
Sorry, something went wrong.
added remove_text to image comparison decorator Co-authored-by: Oscar Gustafsson <oscar.gustafsson@gmail.com> removed inaccurate comments Co-authored-by: Oscar Gustafsson <oscar.gustafsson@gmail.com> removed text from test image and test Update lib/mpl_toolkits/axes_grid1/tests/test_axes_grid1.py changed subfigure generation to default Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com> got rid of colorbar removed colorbar and changed test image
|
In the most recent commit, I removed the colorbar because it wasn't relevant to the test or the issue that this patch is meant to solve. Without the colorbar, the issue still presents itself before the fix and is resolved after it, regardless of the colorbar. |
Sorry, something went wrong.
dstansby
left a comment
There was a problem hiding this comment.
Looks good to me - thanks a lot, especially as this looks like your first PR to Matplotlib!
Sorry, something went wrong.
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
git checkout v3.6.x git pull
git cherry-pick -x -m1 d3cf4291e4a23d7bde39fba96d82cc1416351836
git commit -am 'Backport PR #24783: inset locator fix with tests added'
git push YOURFORK v3.6.x:auto-backport-of-pr-24783-on-v3.6.x
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the Still Needs Manual Backport label once the PR gets merged. If these instructions are inaccurate, feel free to suggest an improvement. |
Sorry, something went wrong.
…783-on-v3.7.x Backport PR #24783 on branch v3.7.x (inset locator fix with tests added)
…v3.6.x "Backport PR #24783 on branch v3.6.x (inset locator fix with tests added)"
PR Summary
Addresses the bug report #24589
From report:
Implemented the proposed resolution and wrote a unit test that validates the image referenced in the bug report is generated properly
PR Checklist
Documentation and Tests
Release Notes