FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix toggling of MultiCursor.{horizOn,vertOn} by QuLogic · Pull Request #24845 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Fix toggling of MultiCursor.{horizOn,vertOn} - #24845

Merged
ksunden merged 1 commit into
matplotlib:mainfrom
QuLogic:cursor-disable
Jan 3, 2023
ConversationCommits (1)ChecksFiles changed
Merged

Fix toggling of MultiCursor.{horizOn,vertOn}#24845
ksunden merged 1 commit into
matplotlib:mainfrom
QuLogic:cursor-disable

Conversation

QuLogic commented Dec 30, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

By implementing _onmove in a similar manner to Cursor. Also, deprecate the related needclear attribute in both widgets.

Followup to #19763.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] New plotting related features are documented with examples.

Release Notes

  • [n/a] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [n/a] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

QuLogic added this to the v3.7.0 milestone Dec 30, 2022
Fix toggling of MultiCursor.{horizOn,vertOn}
2040a32 
By implementing `_onmove` in a similar manner to `Cursor`. Also,
deprecate the related `needclear` attribute in both widgets.

Followup to matplotlib#19763.
QuLogic mentioned this pull request Dec 30, 2022
Merged
4 of 5 tasks
ksunden merged commit 6efcfed into matplotlib:main Jan 3, 2023
QuLogic deleted the cursor-disable branch January 4, 2023 01:11
ksunden mentioned this pull request Jan 30, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ksunden ksunden approved these changes
greglucas greglucas approved these changes

Assignees

No one assigned

Labels

topic: widgets/UI

Projects

None yet

Milestone

v3.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL