Repository navigation
Harmonize exceptions for unknown keyword arguments. - #24889
Merged
QuLogic merged 1 commit intoJan 7, 2023
Merged
QuLogic merged 1 commit into
QuLogic merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
In cases where we have several too many can we still list them all (or the first N>1)? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
FWIW python itself doesn't do so, e.g. >>> def f(x): pass ... >>> f(y=1, z=2) Traceback (most recent call last): File "<stdin>", line 1, in <module> TypeError: f() got an unexpected keyword argument 'y' If you feel strongly about it I can still print all of them, but I tend to prefer consistency with python here. |
Sorry, something went wrong.
anntzer
force-pushed
the
ke
branch
2 times, most recently
from
be68641 to
0272560
Compare
January 5, 2023 22:31
QuLogic
reviewed
Jan 5, 2023
Comment thread
lib/matplotlib/image.py
Outdated
... via a kwarg_error helper (see nargs_error for a similar design). In particular the type of the exception thrown by AxesImage.set_extent changed, and parentheses were added to the error thrown by _process_plot_var_args.
oscargus
approved these changes
Jan 6, 2023
QuLogic
approved these changes
Jan 7, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... via a kwarg_error helper (see nargs_error for a similar design). In particular the type of the exception thrown by AxesImage.set_extent changed, and parentheses were added to the error thrown by _process_plot_var_args.
PR Summary
PR Checklist
Documentation and Tests
Release Notes