FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

STY: make allowed line length 9 longer to 88 from 79 by tacaswell · Pull Request #24893 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

STY: make allowed line length 9 longer to 88 from 79 #24893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timhoffm merged 4 commits into from
Jan 26, 2023
Conversation 19 Commits 4 Checks 0 Files changed
Merged

STY: make allowed line length 9 longer to 88 from 79 #24893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ab92cd
STY: make allowed line length 9 longer to 88 from 79
tacaswell Jan 6, 2023
2061607
STY: Document line change bump to 88 char
ksunden Jan 25, 2023
5d78563
Add superseded note to MEP8
ksunden Jan 25, 2023
c898957
Terser statements (from review comments)
ksunden Jan 26, 2023
File filter

Filter by extension

Filter by extension .rst  (3) dotfile  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 1 addition & 1 deletion .flake8
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[flake8]
max-line-length = 79
max-line-length = 88
select =
# flake8 default
C90, E, F, W,
Expand Down
8 changes: 8 additions & 0 deletions doc/api/next_api_changes/development/24893-KS.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
Maximum line length increased to 88 characters
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The maximum line length for new contributions has been extended from 79 characters to
88 characters.
This change provides an extra 9 characters to allow code which is a single idea to fit

jklymak Jan 25, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I find the wrapping here is somehow trying to tell me something ;-)
on fewer lines (often a single line).
The chosen length is the same as `black <https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length>`_.
5 changes: 4 additions & 1 deletion doc/devel/MEP/MEP08.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@
Status
======

**Completed**
**Superseded**

Current guidelines for style, including usage of pep8 are maintained
in `our pull request guidelines <https://matplotlib.org/devdocs/devel/coding_guide.html>`_.

We are currently enforcing a sub-set of pep8 on new code contributions.

Expand Down
8 changes: 7 additions & 1 deletion doc/devel/coding_guide.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ rules before submitting a pull request:
for more details.

* Formatting should follow the recommendations of PEP8_, as enforced by
flake8_. You can check flake8 compliance from the command line with ::
flake8_. Matplotlib modifies PEP8 to extend the maximum line length to 88
characters. You can check flake8 compliance from the command line with ::

python -m pip install flake8
flake8 /path/to/module.py
Expand Down Expand Up @@ -156,6 +157,11 @@ Content topics:
* Does the PR conform with the :ref:`coding_guidelines`?
* Is the :ref:`documentation <pr-documentation>` (docstrings, examples,
what's new, API changes) updated?
* Is the change purely stylistic? Generally, such changes are discouraged when
not part of other non-stylistic work because it obscures the git history of
functional changes to the code. Reflowing a method or docstring as part of a
larger refactor/rewrite is acceptable.


Organizational topics:

Expand Down
Back | FazBrowse Home | New Git URL