FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Expire deprecations from 3.6 by oscargus · Pull Request #24984 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Expire deprecations from 3.6 - #24984

Merged
ksunden merged 35 commits into
matplotlib:mainfrom
oscargus:pickradius
Mar 8, 2023
ConversationCommits (35)ChecksFiles changed
Merged

Expire deprecations from 3.6#24984
ksunden merged 35 commits into
matplotlib:mainfrom
oscargus:pickradius

Conversation

oscargus commented Jan 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

Not all, but most (all?) of the ones I understood (quite) easily...

Split into multiple commits for somewhat sensible commit messages. Will add an api-change note.

The first commit also improves the argument checking of (set_)pickradius slightly.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

oscargus added this to the v3.8.0 milestone Jan 14, 2023
oscargus force-pushed the pickradius branch 4 times, most recently from dbb0c54 to f97e5f5 Compare January 14, 2023 15:14
oscargus commented Jan 14, 2023
View reviewed changes
Comment thread doc/users/prev_whats_new/dflt_style_changes.rst
ax_bottom.set_ylim(0, .75)
ax_bottom.add_artist(mpatches.Rectangle(grid[1] - [0.025, 0.05],
0.05, 0.1))
ax_bottom.add_artist(mpatches.RegularPolygon(grid[3], 5, 0.1))

oscargus Jan 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

One would have expected this to warn earlier?

Edit: it did warn, but it seems like the doc-build didn't pick it up.

This was referenced Jan 15, 2023
Open
Open
oscargus marked this pull request as ready for review January 15, 2023 19:36

efiring commented Jan 16, 2023

Copy link
Copy Markdown
Member

Thank you for doing this. I read through the file diffs without finding any problems. I did not try to match every removal with a note in the changes/removals file, but I did notice that removals from the backends don't seem to be mentioned there.

oscargus commented Jan 16, 2023

Copy link
Copy Markdown
Member Author

Ahh, you are correct. Well spotted!

In the 3.6 documents it was a big list of all the backend changes, but I didn't touch the interactive ones, so at the time I just skipped that for later and forgot about it...

oscargus commented Jan 16, 2023

Copy link
Copy Markdown
Member Author

This is now added.

Note that some of the things didn't have deprecation notices in the 3.6 docs, such as positional argument renaming.

oscargus mentioned this pull request Mar 5, 2023
Closed
6 tasks
anntzer reviewed Mar 5, 2023
View reviewed changes
Comment thread doc/api/next_api_changes/removals/24984-OG.rst Outdated
anntzer reviewed Mar 5, 2023
View reviewed changes
Comment thread lib/matplotlib/mlab.py Outdated
anntzer reviewed Mar 5, 2023
View reviewed changes
Comment thread lib/mpl_toolkits/mplot3d/axis3d.py Outdated

oscargus commented Mar 6, 2023

Copy link
Copy Markdown
Member Author

Thanks @anntzer ! Should be sorted out now.

anntzer approved these changes Mar 6, 2023
View reviewed changes

anntzer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

postci

ksunden reviewed Mar 6, 2023
View reviewed changes
Comment thread lib/matplotlib/collections.py Outdated
ksunden reviewed Mar 6, 2023
View reviewed changes
Comment thread lib/matplotlib/offsetbox.py Outdated
ksunden requested changes Mar 6, 2023
View reviewed changes

ksunden left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Only hard blocker is the offsetbox kw-only arg position, but also commented on collections version of pickradius if you wish to make that consistent with some other pickradus implementations

oscargus commented Mar 7, 2023

Copy link
Copy Markdown
Member Author

Thanks @ksunden ! Good finds!

ksunden merged commit c9bd855 into matplotlib:main Mar 8, 2023
oscargus deleted the pickradius branch March 8, 2023 22:32
ksunden mentioned this pull request Mar 8, 2023
Merged
3 of 10 tasks
ksunden mentioned this pull request Apr 27, 2023
Merged
6 tasks
ksunden mentioned this pull request Jun 5, 2023
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anntzer anntzer approved these changes
ksunden ksunden approved these changes

Assignees

No one assigned

Labels

Maintenance

Projects

None yet

Milestone

v3.8.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL