FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Deprecate unused/undocumented functions in proj3d by oscargus · Pull Request #24985 · matplotlib/matplotlib · GitHub

Repository navigation

Deprecate unused/undocumented functions in proj3d - #24985

Merged
ksunden merged 1 commit into
matplotlib:mainfrom
oscargus:deprecateproj3d
Jan 30, 2023
Merged

ksunden merged 1 commit into
matplotlib:mainfrom
oscargus:deprecateproj3d

Conversation

oscargus commented Jan 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

Related to #24098

A bit arbitrary, but primarily unused in the code base (or only used once) and/or not documented (or scarcely documented). Some of more general interest remains, see #23449 (comment)

Will add api change notes.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

oscargus marked this pull request as ready for review January 14, 2023 20:05

scottshambaugh left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm!

ksunden merged commit 9296df8 into matplotlib:main Jan 30, 2023
oscargus deleted the deprecateproj3d branch February 1, 2023 23:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL