FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update Release guide to current practices by QuLogic · Pull Request #25023 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Update Release guide to current practices - #25023

Merged
ksunden merged 4 commits into
matplotlib:mainfrom
QuLogic:release-guide
Jan 27, 2023
ConversationCommits (4)ChecksFiles changed
Merged

Update Release guide to current practices#25023
ksunden merged 4 commits into
matplotlib:mainfrom
QuLogic:release-guide

Conversation

QuLogic commented Jan 18, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

This updates the release guide to follow what I currently do. It also updates the helper scripts to clean up some minor whitespace issues that I always need to fix before committing.

Note that this is wrapped at 88, so may have to wait for PR #24893 to go in.

PR Checklist

Documentation and Tests

  • [n/a] Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] New plotting related features are documented with examples.

Release Notes

  • [n/a] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [n/a] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • [n/a] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

QuLogic added this to the v3.8.0 milestone Jan 18, 2023
tacaswell approved these changes Jan 18, 2023
View reviewed changes

tacaswell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

modulo waiting for the line length to be relaxed.

story645 reviewed Jan 18, 2023
View reviewed changes
Comment thread doc/devel/release_guide.rst Outdated
Comment on lines +44 to +46
API. Copy the current :file:`doc/users/github_stats.rst` to
:file:`doc/users/prev_whats_new/github_stats_{X}.{Y}.{Z}.rst`, changing the link target
at the top of the file, and removing the "Previous GitHub Stats" section at the end.

story645 Jan 18, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Any chance this can be changed to a numbered list of steps? And the tenses here confuse me - does copying auto change things or do they need to be changed manually?

QuLogic Jan 19, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

There is an implied 'while' before the 'changing'.

story645 Jan 19, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can it be explicit?

QuLogic Jan 19, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sure

QuLogic mentioned this pull request Jan 20, 2023
Merged

QuLogic commented Jan 25, 2023

Copy link
Copy Markdown
Member Author

Note for later: add instruction to check spelling in GitHub stats, re #25084

Clean up GitHub statistics script
0bddc7b 
This clears up the flake8 exception, and corrects the title and trailing
whitespace that I always need to clean up when committing the file.
Fix extra line in Zenodo cache script
cf6f76d 
Every run of the script adds an extra newline at the end.
Update release guide for current practices
9d5837f

ksunden commented Jan 26, 2023

Copy link
Copy Markdown
Member

Rebased and fixed the one remaining flake8 error (docstring in tools/github_stats.py)

Should be good to merge upon CI passing. (Was waiting for the line length bump)

ksunden merged commit 84cc898 into matplotlib:main Jan 27, 2023
QuLogic deleted the release-guide branch February 21, 2023 18:43
QuLogic mentioned this pull request Feb 21, 2023
Merged
3 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tacaswell tacaswell approved these changes
story645 story645 approved these changes

Assignees

No one assigned

Labels

Documentation Maintenance

Projects

None yet

Milestone

v3.8.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL