FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix FigureCanvasTkAgg memory leak via weakrefs by richardsheridan · Pull Request #25097 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

fix FigureCanvasTkAgg memory leak via weakrefs #25097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ksunden merged 1 commit into from
Feb 7, 2023
Conversation 9 Commits 1 Checks 0 Files changed
Merged

fix FigureCanvasTkAgg memory leak via weakrefs #25097

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
24 changes: 22 additions & 2 deletions lib/matplotlib/backends/_backend_tk.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import uuid
import weakref
from contextlib import contextmanager
import logging
import math
Expand Down Expand Up @@ -198,14 +199,33 @@ def __init__(self, figure=None, master=None):
# event to the window containing the canvas instead.
# See https://wiki.tcl-lang.org/3893 (mousewheel) for details
root = self._tkcanvas.winfo_toplevel()
root.bind("<MouseWheel>", self.scroll_event_windows, "+")

# Prevent long-lived references via tkinter callback structure GH-24820
weakself = weakref.ref(self)
weakroot = weakref.ref(root)

def scroll_event_windows(event):
self = weakself()
if self is None:
root = weakroot()
if root is not None:
root.unbind("<MouseWheel>", scroll_event_windows_id)
Comment thread
ksunden marked this conversation as resolved.
return
return self.scroll_event_windows(event)
scroll_event_windows_id = root.bind("<MouseWheel>", scroll_event_windows, "+")

# Can't get destroy events by binding to _tkcanvas. Therefore, bind
# to the window and filter.
def filter_destroy(event):
self = weakself()
if self is None:
root = weakroot()
if root is not None:
root.unbind("<Destroy>", filter_destroy_id)
return
if event.widget is self._tkcanvas:
CloseEvent("close_event", self)._process()
root.bind("<Destroy>", filter_destroy, "+")
filter_destroy_id = root.bind("<Destroy>", filter_destroy, "+")

self._tkcanvas.focus_set()

Expand Down
Back | FazBrowse Home | New Git URL