FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Deprecate LocationEvent.lastevent. by anntzer · Pull Request #25101 · matplotlib/matplotlib · GitHub

Repository navigation

Deprecate LocationEvent.lastevent. - #25101

Merged
ksunden merged 1 commit into
matplotlib:mainfrom
anntzer:le
Feb 8, 2023
Merged

ksunden merged 1 commit into
matplotlib:mainfrom
anntzer:le

Conversation

anntzer commented Jan 27, 2023

Copy link
Copy Markdown
Contributor

Keeping around lastevent can delay garbage collection of a torn-down axes, and can also keep around an actual GUI event object (guiEvent) associated with a long-torn down widget, which can be problematic for some GUI toolkits.

Instead, only keep track of the last inaxes attribute.

Unfortunately there are no tests for axes_enter_event/axes_leave_event, but this can be manually tested by running the
event_handling/figure_axes_enter_leave.py example.

See #24820, #22211 (comment).

PR Summary

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

anntzer force-pushed the le branch 2 times, most recently from b9fc4e5 to 6b7e181 Compare January 27, 2023 22:00
Keeping around lastevent can delay garbage collection of a torn-down
axes, and can also keep around an actual GUI event object (guiEvent)
associated with a long-torn down widget, which can be problematic for
some GUI toolkits.

Instead, only keep track of the last inaxes attribute.

Unfortunately there are no tests for axes_enter_event/axes_leave_event,
but this can be manually tested by running the
event_handling/figure_axes_enter_leave.py example.
ksunden added this to the v3.8.0 milestone Feb 8, 2023
ksunden merged commit 2b938cd into matplotlib:main Feb 8, 2023
anntzer deleted the le branch February 8, 2023 06:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL