| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Since 958e329 the preferred keyword for controlling the number of columns in a legend is `ncols`, but some code examples have still been using `ncol`.
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks @eerovaher! I think we just need to wait for the CI to pass…
Sorry, something went wrong.
There was a problem hiding this comment.
rerunning tests which failed for seemingly unrelated reasons (macos subprocess timeout, though test_blit, not the most common test_interactive)
Anyone can merge on green CI
Sorry, something went wrong.
…110-on-v3.7.x Backport PR #25110 on branch v3.7.x (Stop recommending `ncol` in legend examples)
|
Thank you for submitting your first PR to Matplotlib @eerovaher. We hope to hear from you again. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
Since 958e329 the preferred keyword for controlling the number of columns in a legend is ncols. However,
reveals several uses of the old keyword. This pull request replaces most of them with the new recommended ncols, but three uses of ncol should remain in place:
matplotlib/doc/users/prev_whats_new/whats_new_0.98.4.rst
Line 40 in a30c0b1
matplotlib/lib/matplotlib/legend.py
Line 383 in a30c0b1
matplotlib/lib/matplotlib/tests/test_legend.py
Line 1220 in a30c0b1
PR Checklist
Documentation and Tests
Release Notes