FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Disconnect SubplotTool destroyer callback on tool_fig close by richardsheridan · Pull Request #25158 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Disconnect SubplotTool destroyer callback on tool_fig close - #25158

Merged
ksunden merged 1 commit into
matplotlib:mainfrom
richardsheridan:24395-any-resizing-of-the-plot-after-pltshow-results-in-an-error-when-closing-the-window
Feb 6, 2023
ConversationCommits (1)ChecksFiles changed
Merged

Disconnect SubplotTool destroyer callback on tool_fig close#25158
ksunden merged 1 commit into
matplotlib:mainfrom
richardsheridan:24395-any-resizing-of-the-plot-after-pltshow-results-in-an-error-when-closing-the-window

Conversation

richardsheridan commented Feb 5, 2023

Copy link
Copy Markdown
Contributor

PR Summary

Fixes #24395.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

tacaswell commented Feb 6, 2023

Copy link
Copy Markdown
Member

For those following at home the problem sequence is:

  • make (tk) figure
  • open the parameter adjustment window (this adds a callback to close child window when the main window is closed)
  • close the parameter adjustment window
  • close the main window (which complains it can not close the already closed parameter window)

The fix is to remove the callback that closes the parameter window when the parameter window is closed.

tacaswell added this to the v3.7.0 milestone Feb 6, 2023
ksunden merged commit 5eb3988 into matplotlib:main Feb 6, 2023
meeseeksmachine mentioned this pull request Feb 6, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 6, 2023
Backport PR matplotlib#25158: Disconnect SubplotTool destroyer callba…
613845b 
…ck on tool_fig close
richardsheridan deleted the 24395-any-resizing-of-the-plot-after-pltshow-results-in-an-error-when-closing-the-window branch February 6, 2023 15:53
ksunden added a commit that referenced this pull request Feb 7, 2023
Merge pull request #25161 from meeseeksmachine/auto-backport-of-pr-25…
0bafdf2 
…158-on-v3.7.x

Backport PR #25158 on branch v3.7.x (Disconnect SubplotTool destroyer callback on tool_fig close)
ksunden mentioned this pull request Feb 20, 2023
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tacaswell tacaswell approved these changes
ksunden ksunden approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.7.0

Development

Successfully merging this pull request may close these issues.

Any resizing of the plot after plt.show results in an error when closing the window

3 participants

Back | FazBrowse Home | New Git URL