Repository navigation
FIX: do not use deprecated API internally - #25183
Merged
ksunden merged 1 commit intoFeb 9, 2023
Merged
ksunden merged 1 commit into
ksunden merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ksunden
approved these changes
Feb 9, 2023
jklymak
approved these changes
Feb 9, 2023
anntzer
approved these changes
Feb 9, 2023
Copy link
Copy Markdown
Contributor
|
anyone can merge postci |
Sorry, something went wrong.
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Feb 9, 2023
ksunden
added a commit
that referenced
this pull request
Feb 10, 2023
…183-on-v3.7.x Backport PR #25183 on branch v3.7.x (FIX: do not use deprecated API internally)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25181
PR Summary
I'm not sure how to test this without invoking a lot of notebook machinery....
On this branch we have:
$ git grep 'close_event(' lib/matplotlib/backend_bases.py: def close_event(self, guiEvent=None)