Repository navigation
DOC: document fmt_xdata, fmt_ydata, and fmt_zdata - #25187
tacaswell wants to merge 6 commits into
Conversation
Sorry, something went wrong.
|
Makes sense to add the same to matplotlib/lib/mpl_toolkits/mplot3d/axes3d.py Lines 161 to 162 in 91d8f2e ? This may just as well go in 3.7? (I guess it would if there was a 3.7-doc? Edit: no, not in 3.7-doc as it also changes the lib-files, but still...) |
Sorry, something went wrong.
|
Do we want to get this in prior 3.7.1, which we are looking to tag today? |
Sorry, something went wrong.
|
Just thought that I'd highlight #17286 as it is sort of related to this. At least the suggestion to rename this attribute and/or have setters/getters for it. Doesn't have to be a show stopper for this PR though. |
Sorry, something went wrong.
|
This can't get pulled back to the doc branch (it touches library code). |
Sorry, something went wrong.
|
I'm a bit torn how to do this properly. The fundamental issue is that attributes are a dynamic concept and it's hard to attach meta information to them. Actually I don't like either approach: Class level type annotations are a bit awkward because we have otherwise pushed all typing to the stubs. OTOH I also don't like to create class attributes for documentation when we actually have instance attributes. If I have to choose between those, I'd go for the type annotations, but YMMV. |
Sorry, something went wrong.
|
If we have two other instances of using the typing style and @timhoffm prefers it, go with that method! |
Sorry, something went wrong.
|
Oh it seems it doesn't work for 3D. Is that because we have not typed the module more generally? |
Sorry, something went wrong.
|
Doc build failure due to
But I don't really understand why this is the case. |
Sorry, something went wrong.
|
Well, the warning seems right, because it doesn't seem like it's there: https://output.circle-artifacts.com/output/job/1e67683f-805a-4e9c-aa1c-f54e82d0df21/artifacts/0/doc/build/html/api/toolkits/mplot3d/axes3d.html#interactive |
Sorry, something went wrong.
| Axes._shared_axes["z"] = cbook.Grouper() | ||
| Axes._shared_axes["view"] = cbook.Grouper() | ||
|
|
||
| fmt_zdata: Callable[[float], str] | None |
There was a problem hiding this comment.
Setting this to something seems to fix it, though again, not sure why it doesn't seem necessary on the others.
| fmt_zdata: Callable[[float], str] | None | |
| fmt_zdata: Callable[[float], str] | None = None |
Sorry, something went wrong.
There was a problem hiding this comment.
I just had an idea... Neither of these exist as attributes on the class:
>>> from matplotlib.axes import Axes
>>> Axes.fmt_xdata
Traceback (most recent call last):
File "<python-input-1>", line 1, in <module>
Axes.fmt_xdata
AttributeError: type object 'Axes' has no attribute 'fmt_xdata'. Did you mean: 'format_xdata'?
>>> from mpl_toolkits.mplot3d.axes3d import Axes3D
>>> Axes3D.fmt_zdata
Traceback (most recent call last):
File "<python-input-3>", line 1, in <module>
Axes3D.fmt_zdata
AttributeError: type object 'Axes3D' has no attribute 'fmt_zdata'. Did you mean: 'format_zdata'?
and yet the former works.
But the difference between 2D and 3D Axes is the former has type stubs and the latter doesn't. Unfortunately, removing fmt_xdata/fmt_ydata from the _base.pyi type stub did not break the docs. So I still don't know why it doesn't work.
Sorry, something went wrong.
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
PR Summary
Closes #9593
This documents the exact call chain so we can leave the monkey patching route implicit ;)