FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add deprecation for setting data with non sequence type in `Line2D` by ericpre · Pull Request #25196 · matplotlib/matplotlib · GitHub

Repository navigation

Add deprecation for setting data with non sequence type in Line2D - #25196

Merged
oscargus merged 2 commits into
matplotlib:mainfrom
ericpre:add_deprecation_sequence_set_data_line
Feb 12, 2023
Merged

oscargus merged 2 commits into
matplotlib:mainfrom
ericpre:add_deprecation_sequence_set_data_line

Conversation

ericpre commented Feb 11, 2023

Copy link
Copy Markdown
Member

Follow up on #22329 to add a deprecation cycle for this API change and avoid breaking dependent libraries! :)

PR Summary

The following will now raise a MatplotlibDeprecationWarning instead of RuntimeError:

import matplotlib.pyplot as plt

fig, ax = plt.subplots()
l = ax.axhline(y=0.5)
l.set_ydata(0.25)

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] New plotting related features are documented with examples.

Release Notes

  • [n/a] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [n/a] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

ericpre force-pushed the add_deprecation_sequence_set_data_line branch from c8a44ac to 044fbc0 Compare February 11, 2023 12:11
ericpre changed the base branch from v3.7.x to main February 11, 2023 12:11
rcomer added this to the v3.7.0 milestone Feb 11, 2023
jklymak added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Feb 11, 2023
oscargus merged commit 545b581 into matplotlib:main Feb 12, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 12, 2023
dstansby pushed a commit that referenced this pull request Feb 12, 2023
…e type in `Line2D` (#25201)

Co-authored-by: Oscar Gustafsson <oscar.gustafsson@gmail.com>
ksunden mentioned this pull request Feb 20, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL