FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deleting __init__.py from matplotlib/lib/mpl_toolkits by BabaYaga1221 · Pull Request #25441 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

deleting __init__.py from matplotlib/lib/mpl_toolkits - #25441

Closed
BabaYaga1221 wants to merge 1 commit into
matplotlib:mainfrom
BabaYaga1221:matplotlib_update
ConversationCommits (1)ChecksFiles changed
Closed

deleting __init__.py from matplotlib/lib/mpl_toolkits#25441
BabaYaga1221 wants to merge 1 commit into
matplotlib:mainfrom
BabaYaga1221:matplotlib_update

Conversation

BabaYaga1221 commented Mar 12, 2023 •
edited
Loading

Copy link
Copy Markdown

PR Summary

delete init.py file to resolve issue #25244

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

BabaYaga1221 commented Mar 12, 2023

Copy link
Copy Markdown
Author

@tacaswell as you mention in issue #25244 to delete init.py and update docs. I delete the file but in reference to my comment on the issue, I think is just about the python version problem. Correct me, if I am wrong because I am a begineer in open-source. thanks

github-actions Bot reviewed Mar 12, 2023
View reviewed changes

github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

oscargus commented Mar 13, 2023

Copy link
Copy Markdown
Member

Duplicate of #25381

oscargus marked this as a duplicate of #25381 Mar 13, 2023

tacaswell commented Mar 13, 2023

Copy link
Copy Markdown
Member

Thank you for your work @BabaYaga1221 , however I'm going to close this in favor of #25381 which already has a bunch of discussion and includes API change notes.

We hope to hear from you again!

tacaswell closed this Mar 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

github-actions[bot] github-actions[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL